Commit 4c7c19b
Prepare clients for localized lobby notices
The server change introduces optional notice localization metadata while preserving legacy text. This updates the shared lobby contract first so downstream clients can adopt the fields without raw JSON handling.
Constraint: FAF server PR 1083 adds optional notice localization fields while keeping legacy text for existing clients.
Rejected: Client-only parsing workaround | shared lobby API should model the server contract first.
Confidence: high
Scope-risk: narrow
Directive: Keep the two-argument NoticeInfo constructor available for Java callers until client consumers migrate.
Tested: JAVA_HOME=/Users/yoseph/Codexperiment/.deps/jdk21/Contents/Home ./gradlew :lobby:test --tests com.faforever.commons.lobby.ServerMessageTest
Tested: git diff --check
Not-tested: Full Gradle suite.
Co-authored-by: OmX <omx@oh-my-codex.dev>1 parent 50328af commit 4c7c19b
2 files changed
Lines changed: 35 additions & 2 deletions
File tree
- lobby/src
- main/kotlin/com/faforever/commons/lobby
- test/kotlin/com/faforever/commons/lobby
Lines changed: 8 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| |||
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
52 | | - | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
55 | 62 | | |
56 | 63 | | |
57 | 64 | | |
| |||
210 | 217 | | |
211 | 218 | | |
212 | 219 | | |
213 | | - | |
| |||
Lines changed: 27 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
101 | 101 | | |
102 | 102 | | |
103 | 103 | | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
104 | 131 | | |
105 | 132 | | |
106 | 133 | | |
| |||
0 commit comments