Skip to content

Commit 770f559

Browse files
committed
rename TestSparqlPost to TestSearchSparqlController and rename test methods for clarity
for clarity, we're not following the project test naming convention
1 parent 70a02fc commit 770f559

1 file changed

Lines changed: 8 additions & 7 deletions

File tree

src/test/java/nl/dtls/fairdatapoint/acceptance/search/sparql/TestSparqlPost.java renamed to src/test/java/nl/dtls/fairdatapoint/acceptance/search/sparql/TestSearchSparqlController.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
import static org.junit.jupiter.api.Assertions.*;
4444

4545
@DisplayName("POST /search/sparql")
46-
public class TestSparqlPost extends WebIntegrationTest {
46+
public class TestSearchSparqlController extends WebIntegrationTest {
4747

4848
private final URI url = URI.create("/search/sparql");
4949

@@ -52,7 +52,7 @@ public class TestSparqlPost extends WebIntegrationTest {
5252
private final String querySelectAll = "SELECT * WHERE { ?s ?p ?o }";
5353

5454
@Test
55-
public void sparqlPostUnauthenticated() throws JsonProcessingException {
55+
public void postSparqlUnauthenticated() throws JsonProcessingException {
5656
// prepare request
5757
SearchSparqlController.SparqlQuery sparqlQuery = new SearchSparqlController.SparqlQuery(
5858
querySelectAll, null, null);
@@ -73,7 +73,7 @@ public void sparqlPostUnauthenticated() throws JsonProcessingException {
7373
}
7474

7575
@Test
76-
public void sparqlPostSelectAll() throws JsonProcessingException {
76+
public void postSparqlSelectAll() throws JsonProcessingException {
7777
// prepare request
7878
SearchSparqlController.SparqlQuery sparqlQuery = new SearchSparqlController.SparqlQuery(
7979
querySelectAll, null, null);
@@ -91,6 +91,7 @@ public void sparqlPostSelectAll() throws JsonProcessingException {
9191
assertEquals(HttpStatus.OK, response.getStatusCode());
9292
HashMap<String, Object> responseBodyMap = jsonMapper.readValue(response.getBody(), new TypeReference<>() {
9393
});
94+
9495
// expected SPARQL SELECT result structure: https://www.w3.org/TR/sparql11-results-json/
9596
assertEquals(Set.of("head", "results"), responseBodyMap.keySet());
9697
if (responseBodyMap.get("results") instanceof HashMap<?, ?> results) {
@@ -99,7 +100,7 @@ public void sparqlPostSelectAll() throws JsonProcessingException {
99100
}
100101

101102
@Test
102-
public void sparqlPostAskAny() throws JsonProcessingException {
103+
public void postSparqlAskAny() throws JsonProcessingException {
103104
// prepare request
104105
SearchSparqlController.SparqlQuery sparqlQuery = new SearchSparqlController.SparqlQuery(
105106
"ASK { ?s ?p ?o }", null, null);
@@ -116,6 +117,7 @@ public void sparqlPostAskAny() throws JsonProcessingException {
116117
assertEquals(HttpStatus.OK, response.getStatusCode());
117118
HashMap<String, Object> responseBodyMap = jsonMapper.readValue(response.getBody(), new TypeReference<>() {
118119
});
120+
119121
// expected SPARQL ASK result structure: https://www.w3.org/TR/sparql11-results-json/
120122
assertEquals(Set.of("head", "boolean"), responseBodyMap.keySet());
121123
if (responseBodyMap.get("boolean") instanceof Boolean bool) {
@@ -128,7 +130,7 @@ public void sparqlPostAskAny() throws JsonProcessingException {
128130
"CONSTRUCT WHERE { ?s a <https://w3id.org/fdp/fdp-o#MetadataService> } ",
129131
"DESCRIBE ?s WHERE { ?s a <https://w3id.org/fdp/fdp-o#MetadataService> } "
130132
})
131-
public void sparqlPostConstructOrDescribe(String query) throws JsonProcessingException {
133+
public void postSparqlConstructOrDescribe(String query) throws JsonProcessingException {
132134
// prepare request
133135
SearchSparqlController.SparqlQuery sparqlQuery = new SearchSparqlController.SparqlQuery(
134136
query, null, null);
@@ -171,7 +173,7 @@ public void sparqlPostConstructOrDescribe(String query) throws JsonProcessingExc
171173
"MOVE DEFAULT TO GRAPH ex:",
172174
"ADD DEFAULT TO GRAPH ex:"
173175
})
174-
public void sparqlPostUpdateDenied(String update) throws JsonProcessingException {
176+
public void postSparqlUpdateDenied(String update) throws JsonProcessingException {
175177
// common prefixes (part of prologue in sparql grammar)
176178
final String prologue = """
177179
PREFIX dc: <http://purl.org/dc/terms/>
@@ -193,5 +195,4 @@ public void sparqlPostUpdateDenied(String update) throws JsonProcessingException
193195
// SPARQL Update operations should always be denied
194196
assertEquals(HttpStatus.BAD_REQUEST, response.getStatusCode());
195197
}
196-
197198
}

0 commit comments

Comments
 (0)