Polish code based on reviews

Author: MarekSuchanek

pom.xml

@@ -61,7 +61,6 @@
         <jwt.version>0.12.6</jwt.version>
         <lombok.version>1.18.38</lombok.version>
         <hypersistence.version>3.9.10</hypersistence.version>
-        <jackson.version>3.0.0</jackson.version>
 
         <!-- Test -->
         <httpclient5.version>5.5</httpclient5.version>
@@ -208,11 +207,6 @@
             <artifactId>hypersistence-utils-hibernate-63</artifactId>
             <version>${hypersistence.version}</version>
         </dependency>
-        <dependency>
-            <groupId>tools.jackson.core</groupId>
-            <artifactId>jackson-databind</artifactId>
-            <version>${jackson.version}</version>
-        </dependency>
 
         <dependency>
             <groupId>org.postgresql</groupId>

src/main/java/org/fairdatapoint/config/BootstrapConfig.java

@@ -86,7 +86,7 @@ public Jackson2RepositoryPopulatorFactoryBean repositoryPopulator() {
                 factory.setResources(resources);
             }
             catch (IOException exception) {
-                exception.printStackTrace();
+                log.error("Failed to load relational database fixtures", exception);
             }
         }
         else {

src/main/java/org/fairdatapoint/service/membership/MembershipMapper.java

@@ -47,13 +47,5 @@ public MembershipDTO toDTO(Membership membership) {
     public MembershipPermissionDTO toPermissionDTO(MembershipPermission permission) {
         return new MembershipPermissionDTO(permission.getMask(), permission.getCode());
     }
-
-    public MembershipPermission permissionFromDTO(Membership membership, MembershipPermissionDTO permission) {
-        return MembershipPermission.builder()
-                .membership(membership)
-                .code(permission.getCode())
-                .mask(permission.getMask())
-                .build();
-    }
 }
 

src/main/java/org/fairdatapoint/service/settings/SettingsMapper.java

@@ -191,7 +191,7 @@ public SettingsSearchFilter fromSearchFilterDTO(
         return filter;
     }
 
-    public SettingsSearchFilterItem fromSearchFilterItemDTO(
+    private SettingsSearchFilterItem fromSearchFilterItemDTO(
             SearchFilterItemDTO dto, int orderPriority, SettingsSearchFilter filter
     ) {
         return SettingsSearchFilterItem.builder()