remove 'file:' prefix from fixture location pattern

This allows us to include the prefix in the config, which is more flexible.
For example, we can set file:fixtures for the default fixtures,
which need to be overridable in the docker container,
and we can set classpath:test-fixtures for the test fixtures,
which can then be included in the test/resources dir.

Moreover, this approach is similar to the way flyway.locations are specified.

Author: dennisvang

src/main/java/org/fairdatapoint/config/BootstrapConfig.java

@@ -83,8 +83,7 @@ public Jackson2RepositoryPopulatorFactoryBean repositoryPopulator() {
                 for (String location : this.bootstrap.getLocations()) {
                     // Path.of() removes trailing slashes, so it is safe to concatenate "/*.json".
                     // Note that Path.of(location).resolve("*.json") could work on unix but fails on windows.
-                    final String locationPattern = "file:" + Path.of(location) + "/*.json";
-                    resources.addAll(List.of(resourceResolver.getResources(locationPattern)));
+                    resources.addAll(List.of(resourceResolver.getResources(Path.of(location) + "/*.json")));
                 }
                 // remove resources that have been applied already
                 final List<String> appliedFixtures = fixtureHistoryRepository.findAll().stream()

src/main/java/org/fairdatapoint/config/properties/BootstrapProperties.java

@@ -38,6 +38,7 @@
 public class BootstrapProperties {
     // boolean defaults to false
     private boolean enabled;
-    // locations to search for fixtures
+    // locations to search for fixtures, for example, file:fixtures, relative to project root,
+    // or classpath:fixtures (see PathMatchingResourcePatternResolver docs for valid patterns)
     private List<String> locations;
 }

src/main/resources/application.yml

@@ -115,4 +115,4 @@ server:
 bootstrap:
   enabled: true
   locations:
-    - "fixtures"
+    - file:fixtures

src/test/resources/application-testing.yml

@@ -27,5 +27,5 @@ ping:
 bootstrap:
   enabled: true
   locations:
-    - fixtures
-    - test-fixtures
+    - file:fixtures
+    - classpath:test-fixtures