Skip to content

Commit e9cdead

Browse files
committed
Merge branch 'master' into maintenance/920-upgrade-to-spring-boot-4
pulling in DRY project versioning and some dependency updates
2 parents ace2171 + 888b539 commit e9cdead

7 files changed

Lines changed: 30 additions & 20 deletions

File tree

.github/workflows/code-style.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222

2323
steps:
2424
- name: Checkout repository
25-
uses: actions/checkout@v6
25+
uses: actions/checkout@v7
2626

2727
- name: Setup Java
2828
uses: actions/setup-java@v5
@@ -49,7 +49,7 @@ jobs:
4949

5050
steps:
5151
- name: Checkout repository
52-
uses: actions/checkout@v6
52+
uses: actions/checkout@v7
5353

5454
- name: Setup Java
5555
uses: actions/setup-java@v5
@@ -76,7 +76,7 @@ jobs:
7676

7777
steps:
7878
- name: Checkout repository
79-
uses: actions/checkout@v6
79+
uses: actions/checkout@v7
8080

8181
- name: Setup Java
8282
uses: actions/setup-java@v5

.github/workflows/docker-publish.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,3 +32,5 @@ jobs:
3232
with:
3333
file: './Dockerfile'
3434
push: ${{ github.event_name == 'push' || github.event_name == 'release' }}
35+
build-args: |
36+
"PROJECT_VERSION=${{ github.ref_name }}"

.github/workflows/security.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ jobs:
2727

2828
steps:
2929
- name: Checkout repository
30-
uses: actions/checkout@v6
30+
uses: actions/checkout@v7
3131

3232
- name: Setup Java
3333
uses: actions/setup-java@v5
@@ -63,7 +63,7 @@ jobs:
6363
steps:
6464

6565
- name: Checkout repository
66-
uses: actions/checkout@v6
66+
uses: actions/checkout@v7
6767

6868
- name: Perform Snyk Check (Maven)
6969
uses: snyk/actions/maven@master
@@ -87,12 +87,12 @@ jobs:
8787
steps:
8888

8989
- name: Checkout repository
90-
uses: actions/checkout@v6
90+
uses: actions/checkout@v7
9191

9292
- name: Docker build
9393
run: |
9494
docker pull $PUBLIC_IMAGE:$IMAGE_TAG
95-
docker build --cache-from $PUBLIC_IMAGE:$IMAGE_TAG -t fdp:snyk-test -f Dockerfile .
95+
docker build --build-arg PROJECT_VERSION=x.y.z --cache-from $PUBLIC_IMAGE:$IMAGE_TAG -t fdp:snyk-test -f Dockerfile .
9696
9797
- name: Perform Snyk Check (Docker)
9898
uses: snyk/actions/docker@master

Dockerfile

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ WORKDIR /builder
1111
ADD . /builder
1212

1313
# https://maven.apache.org/ref/current/maven-embedder/cli.html
14-
RUN mvn --quiet --batch-mode --update-snapshots --fail-fast -DskipTests package
14+
ARG PROJECT_VERSION
15+
RUN mvn --quiet --batch-mode --update-snapshots --fail-fast -DskipTests -Drevision=${PROJECT_VERSION} package
1516

1617
################################################################################
1718
# BUILD IMAGE

SECURITY.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,20 +3,20 @@
33
## Supported Versions
44

55
We support the latest *major* and *minor* version with *patch* versions that fix vulnerabilities and critical bugs.
6-
For older versions, we highly recommend upgrading to the latest version.
6+
For older versions, we highly recommend upgrading to the [latest] version.
77

8-
| Version | Supported |
9-
|---------| ------------------ |
10-
| 1.20.x | :white_check_mark: |
11-
| < 1.20 | :x: |
8+
| Version | Supported |
9+
|------------| ------------------ |
10+
| [latest] | :white_check_mark: |
11+
| < [latest] | :x: |
1212

1313
## Current Recommendations
1414

15-
* Always use the [latest release].
15+
* Always use the [latest] release.
1616

1717
## Reporting a Vulnerability
1818

1919
If you encounter a vulnerability, please create a [private security advisory] using the "Report a vulnerability" button at the top of this page.
2020

2121
[private security advisory]: https://docs.github.com/en/code-security/how-tos/report-and-fix-vulnerabilities/privately-reporting-a-security-vulnerability
22-
[latest release]: https://github.com/FAIRDataTeam/FAIRDataPoint/releases/latest
22+
[latest]: https://github.com/FAIRDataTeam/FAIRDataPoint/releases/latest

pom.xml

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
</parent>
1212
<groupId>org.fairdatateam</groupId>
1313
<artifactId>fairdatapoint</artifactId>
14-
<version>1.20.0</version>
14+
<version>${revision}</version>
1515
<packaging>jar</packaging>
1616

1717
<name>FairDataPoint</name>
@@ -46,6 +46,9 @@
4646
<properties>
4747
<!-- Project -->
4848
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
49+
<!-- The `revision` property should be overridden during build, e.g. `mvn -Drevision=v1.20.2 ...` -->
50+
<!-- This is handled automatically in the `docker-publish.yml` workflow, with the help of `PROJECT_VERSION`. -->
51+
<revision>dev</revision>
4952

5053
<!-- Maven -->
5154
<maven.compiler.source>21</maven.compiler.source>
@@ -54,7 +57,7 @@
5457
<!-- Project related -->
5558
<spring-rdf-migration.version>2.0.0</spring-rdf-migration.version>
5659
<rdf-resource-resolver.version>0.2.0</rdf-resource-resolver.version>
57-
<spring-security-acl-mongodb.version>6.0.0</spring-security-acl-mongodb.version>
60+
<spring-security-acl-mongodb.version>6.0.4</spring-security-acl-mongodb.version>
5861

5962
<!-- Core -->
6063
<springdoc-openapi-starter-webmvc-ui.version>3.0.3</springdoc-openapi-starter-webmvc-ui.version>
@@ -68,9 +71,9 @@
6871
<jaxb-api.version>2.3.1</jaxb-api.version>
6972
<git-commit-id-maven-plugin.version>10.0.0</git-commit-id-maven-plugin.version>
7073
<maven-checkstyle-plugin.version>3.6.0</maven-checkstyle-plugin.version>
71-
<checkstyle.version>13.3.0</checkstyle.version>
74+
<checkstyle.version>13.6.0</checkstyle.version>
7275
<spring-javaformat-checkstyle.version>0.0.47</spring-javaformat-checkstyle.version>
73-
<spotbugs-maven-plugin.version>4.9.8.2</spotbugs-maven-plugin.version>
76+
<spotbugs-maven-plugin.version>4.10.2.0</spotbugs-maven-plugin.version>
7477

7578
<!-- required for mockito to function properly (#890) -->
7679
<argLine/>
@@ -402,6 +405,10 @@
402405
<generateGitPropertiesFile>true</generateGitPropertiesFile>
403406
<generateGitPropertiesFilename>${project.build.outputDirectory}/META-INF/git.properties</generateGitPropertiesFilename>
404407
<commitIdGenerationMode>full</commitIdGenerationMode>
408+
<!-- include lightweight tags in git describe (github release creates lightweight tags) -->
409+
<gitDescribe>
410+
<tags>true</tags>
411+
</gitDescribe>
405412
</configuration>
406413
</plugin>
407414
<plugin>

src/main/resources/application.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ metadataProperties:
6767

6868
openapi:
6969
title: FAIR Data Point API
70-
version: 1.20.0
70+
version: "@project.version@"
7171
description: "The reference implementation of the metadata registration service: A service implementing the API specification. It contains an authentication system to allow maintainers to define and update metadata. Read-only access to the data is public."
7272
contact:
7373
name: Luiz Bonino

0 commit comments

Comments
 (0)