Remove rdf4j-generator-maven-plugin dependency#719
Merged
Conversation
* fix: remove rdf4j-generator * fix: checkstyle warnings on DATACITE,FDP, R3D generate classes and remove SCHEMAORG
* remove unused WebAccessControl vocabulary * rename vocabulary.Sio to SIO and use util.ValueFactoryHelper.i for consistency * remove unused terms from DATACITE vocabulary and refactor for consistency * remove unused terms from R3D vocabulary and refactor for consistency * remove unused terms from FDP vocabulary and refactor for consistency
MarekSuchanek
approved these changes
Jun 8, 2025
MarekSuchanek
left a comment
MarekSuchanek
left a comment
Contributor
There was a problem hiding this comment.
I totally agree with this, the generator also caused extra dependencies on external resources during compile time and it was resulting in issues here and there... 👏🏻
Contributor
Author
|
Thanks for the review @MarekSuchanek :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #612
fixes #714
fixes #716
note: for changes to take effect in target/classes on a dev system it may be necessary to reload the maven project and run maven clean before recompiling