Update CORS configuration#930
Merged
Merged
Conversation
settings are equivalent to the original custom CORSFilter.java implementation new implementation based on docs: https://docs.spring.io/spring-framework/reference/web/webmvc-cors.html#mvc-cors-global
this is *in addition to* the web-mvc CORS handling, and uses the web mvc cors config
[no ci]
dennisvang
marked this pull request as ready for review
June 16, 2026 16:00
Contributor
Author
|
the important changes were already reviewed in #578 (for the develop branch) |
[no ci]
dennisvang
added
chore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the custom CORSFilter by a modern implementation based on the spring MVC docs.
CORS settings remain equivalent to the original settings.
(except that we also allow the HEAD method, for completeness)
fixes #929