Correct docker image version for e2e tests in docker-publish workflow#942
Merged
Conversation
Contributor
Author
|
Cannot test the release case without an actual release, but the non-release case works (verified by checking image version in e2e test logs after successful trigger). Release case logic was verified locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FDP releases are tagged like "v1.2.3" but the docker images are published with "1.2.3".
For versioned releases we need to remove the leading "v", otherwise the e2e workflow cannot find the image.
However, for non-release runs, triggered by PRs or commits to "master", the tag can be any string, so we do not want to remove leading "v" there.
This fix looks cumbersome with the extra step for setting-an-output-parameter, but I don't think there is an easier way.