Skip to content

Correct docker image version for e2e tests in docker-publish workflow #942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennisvang merged 2 commits into from
Jun 30, 2026
Merged

Correct docker image version for e2e tests in docker-publish workflow #942

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7a4b8c
add step to extract docker image version for e2e tests in docker-publ…
dennisvang Jun 30, 2026
04275f5
simplify version string cleanup
dennisvang Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/docker-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ jobs:
needs: publish
runs-on: ubuntu-latest
steps:
- name: determine docker image version from ref_name
# We need to remove the leading "v" from version strings like "v1.2.3", but not from tags like "very-nice".
# Unfortunately, we cannot do this inline but need a separate step that stores the result in outputs.
# https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-commands#setting-an-output-parameter
id: image-version
run: |
version="${{ github.ref_name }}"
[[ "$version" == v[0-9]* ]] && version="${version#v}"
echo "IMAGE_VERSION=$version" >> "$GITHUB_OUTPUT"
- name: trigger e2e tests
uses: FAIRDataTeam/github-workflows/.github/actions/repo-dispatch@v3
with:
Expand All @@ -50,6 +59,6 @@ jobs:
event-type: trigger-tests
client-payload: |
{
"fdp_version": "${{ github.ref_name }}",
"fdp_version": "${{ steps.image-version.outputs.IMAGE_VERSION }}",
"fdp_client_version": "latest"
}
Loading