"Fixed" URL problems #2699.#2704
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
prakhyatox
requested changes
Jan 27, 2026
Contributor
prakhyatox
left a comment
prakhyatox
left a comment
There was a problem hiding this comment.
Adding new tag with URL in the name, the text is still converting to URL
Contributor
Author
That's what's supposed to happen. I changed the code from the old version of "if there's http in the code, make the whole thing into a link" to "if there's a valid URL in the text turn only that into a link". To see this, try e.g. "This is the most awesome website: https://fairsharing.org" ...in one of these fields. |
prakhyatox
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will deal with #2699, at the risk of XSS issues. But, if we don't convert text into links then we're bound to get a ticket about links not being clickable. What are your thoughts, @prakhyatox ?