Merge pull request #301 from American-Institutes-for-Research/HEA-986/Times-per-year-rounding-errors

Make OtherCashIncome.times_per_year float as times_per_month may be f…

Author: rhunwicks

apps/baseline/migrations/0039_othercashincome_times_per_year_float.py

@@ -0,0 +1,21 @@
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("baseline", "0038_other_livestock_production"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="othercashincome",
+            name="times_per_year",
+            field=models.FloatField(
+                blank=True,
+                help_text="Number of times in a year that the income is received",
+                null=True,
+                verbose_name="Times per year",
+            ),
+        ),
+    ]

apps/baseline/models.py

@@ -2758,7 +2758,8 @@ class OtherCashIncome(LivelihoodActivity):
         verbose_name=_("Months per year"),
         help_text=_("Number of months in a year that the labor is performed"),
     )
-    times_per_year = models.PositiveSmallIntegerField(
+    # This is a float field because times_per_month may be fractional (e.g. 4.3/month * 12 months = 51.6/year).
+    times_per_year = models.FloatField(
         blank=True,
         null=True,
         verbose_name=_("Times per year"),