Add missing wild_foods_valid_instances in the consolidated_instances …

[girum-air]

No description provided.

[rhunwicks]

@girum-air why is this required? Doesn't the code below on line 345 add the wild_foods_valid_instances?

[girum-air]

@rhunwicks the keys Fishing and WildFoodGathering weren't in the consolidated_instances at the line and that raises key error - Key error 'Fishing' in consolidated_fixture asset when trying to append it using += We might either need the keys added with empty list to initialize, I think that is better and updated it

[rhunwicks]

Would this be better as:

    # Add the wild foods and other cash income instances, if they are present
    for model_name, instances in {**other_cash_income_valid_instances, **wild_foods_valid_instances}.items():
        if instances and model_name != "WealthGroup":
            if model_name not in consolidated_instances:
                consolidated_instances[model_name] = []
            consolidated_instances[model_name] += instances

That way, if we ever have to add additional models in the future it will still work.

[girum-air]

Ok, agreed. Pushed the updates

[rhunwicks]

@girum-air I think we should avoid hard-coding the model names.