Skip to content

FEXCore/Allocator: Make pmr::default_resource a late initialized static object #5212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Sonicadvance1 wants to merge 1 commit into from
+14 −2
Closed

FEXCore/Allocator: Make pmr::default_resource a late initialized static object #5212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions FEXCore/Source/Utils/Allocator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,27 @@
#include <cstdint>
#include <cstdio>
#include <fcntl.h>
#include <mutex>

#ifndef _WIN32
#include <sys/mman.h>
#include <sys/user.h>
#endif

namespace fextl::pmr {
static fextl::pmr::default_resource FEXDefaultResource;
static std::once_flag default_resource_initialized {};
static fextl::pmr::default_resource* FEXDefaultResource {};
alignas(alignof(fextl::pmr::default_resource)) static char FEXDefaultResourcePlacement[sizeof(fextl::pmr::default_resource)];
Copy link
Copy Markdown
Member

@neobrain neobrain Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR same point as in the other related PRs applies here, pending discussion over there.


std::pmr::memory_resource* get_default_resource() {
return &FEXDefaultResource;
// This dance is necessary to avoid an atexit allocator call.
if (FEXDefaultResource) {
return FEXDefaultResource;
}

std::call_once(default_resource_initialized,
[]() { FEXDefaultResource = new (FEXDefaultResourcePlacement) fextl::pmr::default_resource {}; });
return FEXDefaultResource;
}
} // namespace fextl::pmr

Expand Down
Loading