Windows: Introduce a FEX unixlib and use for all linux syscalls#5424
Open
bylaws wants to merge 2 commits into
Open
Windows: Introduce a FEX unixlib and use for all linux syscalls#5424bylaws wants to merge 2 commits into
bylaws wants to merge 2 commits into
Conversation
crueter
suggested changes
Apr 17, 2026
Collaborator
Author
|
updated |
neobrain
reviewed
May 4, 2026
Collaborator
Author
|
updated |
Member
|
Since this is primarily authored by AI tools, I'm going to need to spend extra effort reviewing this PR, which is why I've been putting it off. |
cjacek
reviewed
May 21, 2026
| Dispatcher = *DispatcherPtr; | ||
| #endif | ||
|
|
||
| if (NtQueryVirtualMemory(NtCurrentProcess(), &__ImageBase, MemoryWineUnixFuncs, &UnixlibHandle, sizeof(UnixlibHandle), nullptr)) { |
Contributor
There was a problem hiding this comment.
Current Wine has MemoryWineLoadUnixLibByName, which allows passing unixlib name. With that, it should be possible to share unixlib among wow64 and arm64ec builds. We may backport that to Proton if needed.
Collaborator
Author
There was a problem hiding this comment.
Oh nice, that's much cleaner will switch :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids the ever increasing need to expose obscure or fex-specific linux features in wine patches and instead allows FEX to run its own linux code nicely - this could pave way for faster sigbus handling or smc (with far too much effort to the degree i think it's still a bad idea over hashing)
This is somewhat of a breaking change in that wine fex users will also need to install the unixlibs for full functionality, but seems far better in long-run.
Needs testing with shm stats and madvise naming to confirm it still works though before merging.
Mostly authored by claude, which is much better now than jan I must say