Wow64: Spin loop on atomic with WFE#5660
Open
Sonicadvance1 wants to merge 1 commit into
Open
Conversation
Instead of burning roughly a million watts, put this spinloop on a WFE. This tends to occur on a crash during shutdown that isn't fully able to be avoided. The least we can do is not consume all the power in the world.
lioncash
reviewed
Jul 7, 2026
| } | ||
|
|
||
| template<typename Pred, typename T> | ||
| static inline void WaitBitMaskPred(T* Futex, T BitMask, T ComparisonValue) { |
Contributor
There was a problem hiding this comment.
Rewriting the signature so the template args are reversed, and passing the predicate in like so:
Suggested change
| static inline void WaitBitMaskPred(T* Futex, T BitMask, T ComparisonValue) { | |
| template<typename T, typename Pred> | |
| static inline void WaitBitMaskPred(T* Futex, T BitMask, T ComparisonValue, Pred Predicate) { |
and then invoking it as:
SpinWaitLock::WaitBitMaskPred(TLS.ControlWordAddress(), ControlBits::IN_JIT, 0U, std::equal_to<>());and removing the braces from Pred {} in the implementation would make the interface a little more flexible (and also allow passing regular lambdas in too).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of burning roughly a million watts, put this spinloop on a WFE. This tends to occur on a crash during shutdown that isn't fully able to be avoided. The least we can do is not consume all the power in the world.