Fix various asserts (#4125)

Author: chrisrichardson

cpp/dolfinx/fem/Function.h

@@ -130,8 +130,8 @@ class Function
     std::span<value_type> x_new = x->array();
     for (std::size_t i = 0; i < map.size(); ++i)
     {
-      assert((int)i < x_new.size());
-      assert(map[i] < x_old.size());
+      assert(i < x_new.size());
+      assert(static_cast<std::size_t>(map[i]) < x_old.size());
       x_new[i] = x_old[map[i]];
     }
 

cpp/dolfinx/fem/interpolate.h

@@ -331,7 +331,7 @@ void interpolation_apply(U&& Pi, V&& data, std::span<T> coeffs, int bs)
   else
   {
     assert(data.extent(0) == Pi.extent(1));
-    assert(data.extent(1) == bs);
+    assert(static_cast<int>(data.extent(1)) == bs);
     std::size_t cols = Pi.extent(1);
     for (int k = 0; k < bs; ++k)
     {
@@ -843,7 +843,7 @@ void identity_mapped_evaluation(const FiniteElement<U>& element, bool symmetric,
   const auto [_Pi, pi_shape] = element.interpolation_operator();
   md::mdspan<const U, std::dextents<std::size_t, 2>> Pi(_Pi.data(), pi_shape);
   const std::size_t num_interp_points = Pi.extent(1);
-  assert(Pi.extent(0) == num_scalar_dofs);
+  assert(static_cast<int>(Pi.extent(0)) == num_scalar_dofs);
 
   auto apply_inv_transpose_dof_transformation
       = element.template dof_transformation_fn<T>(
@@ -1040,7 +1040,7 @@ void piola_mapped_evaluation(const FiniteElement<U>& element, bool symmetric,
       apply_inv_trans_dof_transformation(coeffs_b, cell_info, *cell_it, 1);
 
       // Copy interpolation dofs into coefficient vector
-      assert(coeffs_b.size() == num_scalar_dofs);
+      assert(coeffs_b.size() == static_cast<std::size_t>(num_scalar_dofs));
       for (int i = 0; i < num_scalar_dofs; ++i)
       {
         const int dof = i * element_bs + k;

python/CMakeLists.txt

@@ -38,6 +38,7 @@ find_package(nanobind CONFIG REQUIRED)
 enable_language(C)
 
 find_package(DOLFINX REQUIRED CONFIG)
+set_target_properties(dolfinx PROPERTIES SYSTEM OFF)
 
 if(DOLFINX_FOUND)
   message(STATUS "Found DOLFINx at ${DOLFINX_DIR}")
@@ -77,7 +78,7 @@ if(NANOBIND_SABI)
   # mpi4py and petsc4py use generated Cython headers so tell
   # them that the limited API is in use.
   target_compile_definitions(cpp PRIVATE MPI4PY_LIMITED_API=1)
-  # Needing to set CYTHON_COMPILING_IN_LIMITED_API is a bug in 
+  # Needing to set CYTHON_COMPILING_IN_LIMITED_API is a bug in
   # Cython-generated API headers, should become unnecessary with
   # mpi4py/petsc4py releases published using Cython >= 3.1.4
   # https://github.com/cython/cython/issues/7108
@@ -88,10 +89,10 @@ endif()
 include(CheckCXXCompilerFlag)
 
 # Add some strict compiler checks
-check_cxx_compiler_flag("-Wall -Werror -Wextra -pedantic -Wno-sign-compare" HAVE_PEDANTIC)
+check_cxx_compiler_flag("-Wall -Werror -Wextra -pedantic" HAVE_PEDANTIC)
 
 if(HAVE_PEDANTIC)
-  list(APPEND DOLFINX_PY_CXX_DEVELOPER_FLAGS -Wall;-Werror;-Wextra;-pedantic;-Wno-sign-compare)
+  list(APPEND DOLFINX_PY_CXX_DEVELOPER_FLAGS -Wall;-Werror;-Wextra;-pedantic)
 endif()
 
 # Debug flags
@@ -135,7 +136,6 @@ target_compile_options(
 target_compile_definitions(
   cpp PRIVATE $<$<CONFIG:Developer>:${DOLFINX_PY_CXX_DEVELOPER_DEFINITIONS}>
 )
-
 target_compile_definitions(cpp PRIVATE cxx_std_20)
 
 if(ENABLE_CLANG_TIDY)