Add scratch memory input to nonaffine pull back#4126
Open
Conversation
jorgensd
changed the title
jhale
reviewed
Mar 25, 2026
|
|
||
| std::vector<T> Xk_b(tdim); | ||
| mdspan2_t<T> Xk(Xk_b.data(), 1, tdim); | ||
| mdspan2_t<T> dphi(working_array.data(), tdim, num_xnodes); |
Member
There was a problem hiding this comment.
You could put all of these into a struct PullBackNonAffineScratch with a constructor taking the needed integer sizes, which then does the dynamic memory allocation with multiple std::vectors + holds the std::spans and mdspan2_t for use inside the routine.
Then the struct would handle the (in my view, a bit messy and error-prone) offsetting automatically.
Member
There was a problem hiding this comment.
Unless there is some genuine performance benefit from the current approach with just a single span as input - but on my reading, there probably isn't.
Member
There was a problem hiding this comment.
I vibed this out at jhale/pull_back_scratch_memory, if you like it feel free to merge here and tidy it up/fix up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently pull back nonaffine allocate a whole lot of arrays, making it incredibly slow for repeated computation.
This PR makes the scratch memory a mandatory input argument.