Allow expressions with submeshes#4140
Merged
Merged
Conversation
…ordinate element hash
jorgensd
commented
Apr 17, 2026
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
Member
Author
|
@schnellerhase and I got further. Now we are missing a permutation to compare the output of the two approaches, as they produce the same output, but in a permuted order.. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Member
Author
|
Related issue: FEniCS/ffcx#836 |
jorgensd
commented
Jun 1, 2026
schnellerhase
approved these changes
Jun 1, 2026
Co-authored-by: Jørgen Schartum Dokken <dokken92@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With submesh support, it is quite common that one want to evaluate an expression that uses quantities from both the parent and submesh.
This PR extends expression to be able to support:
Other structural changes
pack_coefficientsfordolfinx::fem::Expressioninto a multi-step approach:Other relevant changes
A fix to the DOLFINx Expression on facet code to ensure that it is evaluated based on the global facet orientation. (FEniCS/ffcx#836)
Requires: FEniCS/ffcx#828
Resolves: #3207