Consistent orientation of output of Expression on facets#836
Merged
Conversation
…e on any day, we found this funky bug in FFCx that expressions evaluated on facets were missing a permutation.
|
coverage: 84.685% (+0.02%) from 84.665% — dokken/facet_expression_parent_fix into main |
mscroggs
reviewed
Jun 1, 2026
mscroggs
approved these changes
Jun 1, 2026
jorgensd
changed the title
Expression on facets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an intense debug session with @mscroggs, that outperforms Claude on any day, we found this funky bug in FFCx that expressions evaluated on facets were missing a permutation.
The logic behind this is:
Consider a
trianglewith local verticesand we would like to evaluate an expression on local facet 0
1 --- 2.Then, a point (x=0.2) could either
or
depending of the facet_permutation (which yields a globally consistent orientation). This was disregarded in the first implementation (#672)