From 1013a48926643ad59558f1dacf4cf05b46f75c70 Mon Sep 17 00:00:00 2001 From: "Jack S. Hale" Date: Wed, 10 Jun 2026 10:20:26 +0200 Subject: [PATCH 1/4] Try to get Windows compiler warnings --- .github/workflows/pythonapp.yml | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index a73d911d6..3bc97d179 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -90,7 +90,7 @@ jobs: - name: Run unit tests run: > - python -m pytest test/ + python -m pytest -v test/ -n auto -W error --cov=ffcx/ @@ -117,10 +117,8 @@ jobs: uses: ilammy/msvc-dev-cmd@v1 - name: Run FFCx demos - run: > - pytest demo/test_demos.py - -W error - # -n auto + run: | + pytest -v demo/test_demos.py -W error - name: Build documentation run: | From 3504c6090a252977eee00982ded5982b2c335292 Mon Sep 17 00:00:00 2001 From: "Jack S. Hale" Date: Wed, 10 Jun 2026 10:55:06 +0200 Subject: [PATCH 2/4] Add nuget --- .github/workflows/pythonapp.yml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 3bc97d179..0564b12d7 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -27,8 +27,28 @@ jobs: matrix: os: ["windows-2022", "ubuntu-latest", "macos-latest"] python-version: ["3.11", "3.12", "3.13", "3.14"] + permissions: + packages: write + env: + VCPKG_EXE: C:/vcpkg/vcpkg + FEED_URL: https://nuget.pkg.github.com/FEniCS/index.json + VCPKG_BINARY_SOURCES: "clear;nuget,https://nuget.pkg.github.com/FEniCS/index.json,readwrite" steps: + - name: Add NuGet sources + shell: pwsh + run: | + .$(${{ env.VCPKG_EXE }} fetch nuget) ` + sources add ` + -Source "${{ env.FEED_URL }}" ` + -StorePasswordInClearText ` + -Name GitHubPackages ` + -UserName "${{ env.USERNAME }}" ` + -Password "${{ secrets.GITHUB_TOKEN }}" + .$(${{ env.VCPKG_EXE }} fetch nuget) ` + setapikey "${{ secrets.GITHUB_TOKEN }}" ` + -Source "${{ env.FEED_URL }}" + - name: Checkout FFCx uses: actions/checkout@v6 From 595b9707a3aaf142a8d916c2831cdc2d8167698c Mon Sep 17 00:00:00 2001 From: "Jack S. Hale" Date: Wed, 10 Jun 2026 10:56:35 +0200 Subject: [PATCH 3/4] Enable verbose, remove some gha stuff --- .github/workflows/pythonapp.yml | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 0564b12d7..03630778a 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -65,12 +65,6 @@ jobs: core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || ''); core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || ''); - - name: Set up CMake - if: runner.os == 'Windows' - uses: lukka/get-cmake@latest - with: - cmakeVersion: "~3.30.0" - - name: Install dependencies (non-Python, Linux) if: runner.os == 'Linux' run: | @@ -87,8 +81,6 @@ jobs: - name: Install FEniCS dependencies (Python, Windows) if: runner.os == 'Windows' - env: - VCPKG_BINARY_SOURCES: "clear;x-gha,readwrite" run: | pip install git+https://github.com/FEniCS/ufl.git pip install -v git+https://github.com/FEniCS/basix.git --config-settings=cmake.args=-DINSTALL_RUNTIME_DEPENDENCIES=ON --config-settings=cmake.args=-DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake @@ -110,7 +102,7 @@ jobs: - name: Run unit tests run: > - python -m pytest -v test/ + python -m pytest -vs test/ -n auto -W error --cov=ffcx/ @@ -138,7 +130,7 @@ jobs: - name: Run FFCx demos run: | - pytest -v demo/test_demos.py -W error + pytest -vs demo/test_demos.py -W error - name: Build documentation run: | From 35fd8f019771f0ac2b11911a019dbd690c232678 Mon Sep 17 00:00:00 2001 From: "Jack S. Hale" Date: Wed, 10 Jun 2026 13:58:18 +0200 Subject: [PATCH 4/4] Fix vcpkg nuget --- .github/workflows/pythonapp.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/pythonapp.yml b/.github/workflows/pythonapp.yml index 03630778a..3ddc425c0 100644 --- a/.github/workflows/pythonapp.yml +++ b/.github/workflows/pythonapp.yml @@ -36,6 +36,7 @@ jobs: steps: - name: Add NuGet sources + if: runner.os == 'Windows' shell: pwsh run: | .$(${{ env.VCPKG_EXE }} fetch nuget) ` @@ -57,14 +58,6 @@ jobs: with: python-version: ${{ matrix.python-version }} - - name: Export GitHub Actions cache environment variables (Windows) - if: runner.os == 'Windows' - uses: actions/github-script@v9 - with: - script: | - core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || ''); - core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || ''); - - name: Install dependencies (non-Python, Linux) if: runner.os == 'Linux' run: |