GH-21 comparison check fail for short & empty string. Fixed other small issues - typos, namings.

Author: RuslanZavacky

lib/LanguageDetect.js

@@ -68,7 +68,7 @@ var LanguageDetect = module.exports = function (languageType) {
   this.unicodeMap = dbLang['trigram-unicodemap'];
 
   this.languageType = languageType || null;
-}
+};
 
 LanguageDetect.prototype = {
 
@@ -170,10 +170,11 @@ LanguageDetect.prototype = {
    */
   detect:function (sample, limit) {
     var me = this
-      , limit = +limit || 0
       , scores = [];
 
-    if (sample == '' && sample.length < 3) return [];
+    limit = +limit || 0;
+
+    if (sample == '' || String(sample).length < 3) return [];
 
     var sampleObj = new Parser(sample);
     sampleObj.setPadStart(true);
@@ -184,16 +185,16 @@ LanguageDetect.prototype = {
 
     if (trigramCount == 0) return [];
 
-    var keys = [], i;
+    var keys = [], i, lang;
 
     if (this.useUnicodeNarrowing) {
       var blocks = sampleObj.getUnicodeBlocks()
-        , langs = Object.keys(blocks)
-        , keysLength = langs.length;
+        , languages = Object.keys(blocks)
+        , keysLength = languages.length;
 
-      for (var i = keysLength; i--;) {
-        if (this.unicodeMap[langs[i]]) {
-          for (var lang in this.unicodeMap[langs[i]]) {
+      for (i = keysLength; i--;) {
+        if (this.unicodeMap[languages[i]]) {
+          for (lang in this.unicodeMap[languages[i]]) {
             if (!~keys.indexOf(lang)) keys.push(lang);
           }
         }
@@ -229,4 +230,4 @@ LanguageDetect.prototype = {
     // limit the number of returned scores
     return limit > 0 ? scores.slice(0, limit) : scores;
   }
-}
+};

test/LanguageDetect.test.js

@@ -81,6 +81,17 @@ exports.getLanguageCount = function (t) {
   return t.done();
 };
 
+exports.detectShortString = function(t) {
+  var l = new LanguageDetect();
+
+  t.deepEqual([], l.detect(''));
+  t.deepEqual([], l.detect('a'));
+  t.deepEqual([], l.detect('ab'));
+  t.notDeepEqual([], l.detect('abc'));
+
+  return t.done();
+};
+
 exports.detectEnglish = function (t) {
   var l = new LanguageDetect();