Skip to content

2025 04 gg issue58#60

Merged
dotasek merged 3 commits into
masterfrom
2025-04-gg-issue58
Apr 22, 2025
Merged

2025 04 gg issue58#60
dotasek merged 3 commits into
masterfrom
2025-04-gg-issue58

Conversation

@grahamegrieve
Copy link
Copy Markdown
Contributor

No description provided.

@grahamegrieve
Copy link
Copy Markdown
Contributor Author

@dotasek

@grahamegrieve grahamegrieve requested a review from dotasek April 22, 2025 01:55
@grahamegrieve
Copy link
Copy Markdown
Contributor Author

Addresses Issue #59 (not 58)

@guiste10
Copy link
Copy Markdown

guiste10 commented Apr 22, 2025

Hello @grahamegrieve, wouldn't it be safer to keep the date as a string in case a new unsupported format will be encountered in the future? That was the solution I came up with (see commit) 4a1d177

@grahamegrieve
Copy link
Copy Markdown
Contributor Author

well, it could be, but that would be a change to the public API. So I'm not keen on that

Copy link
Copy Markdown
Collaborator

@dotasek dotasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dotasek dotasek merged commit d024e63 into master Apr 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants