minor qol

Author: FredHappyface

licensecheck/checker.py

@@ -42,7 +42,7 @@ def check(
 	)
 	failLicensesType = license_matrix.licenseType(ucstr(JOINS.join(fail_licenses)), ignore_licenses)
 	onlyLicensesType = license_matrix.licenseType(ucstr(JOINS.join(only_licenses)), ignore_licenses)
-	# licenseType will always return NO_LICENSE when onlyLicenses is empty          # noqa: ERA001
+	# licenseType will always return NO_LICENSE when onlyLicenses is empty
 	if License.NO_LICENSE in onlyLicensesType:
 		onlyLicensesType.remove(License.NO_LICENSE)
 

licensecheck/cli.py

@@ -99,7 +99,6 @@ def cli() -> None:  # pragma: no cover
 	parser.add_argument(
 		"--pypi-api",
 		help="Specify a custom pypi api endpoint, for example if using a custom pypi server",
-		default="https://pypi.org",
 	)
 	parser.add_argument(
 		"--zero",
@@ -153,7 +152,7 @@ def main(args: dict[str, Any]) -> int:
 	output_file = (
 		stdout
 		if scopedConfig.get("file") in [None, ""]
-		else Path(scopedConfig.get("file")).open("w", encoding="utf-8")
+		else Path(scopedConfig.get("file", "")).open("w", encoding="utf-8")
 	)
 
 	# Get my license
@@ -163,7 +162,9 @@ def main(args: dict[str, Any]) -> int:
 	def getFromConfig(key: str) -> set[types.ucstr]:
 		return set(map(types.ucstr, scopedConfig.get(key, [])))
 
-	package_info_manager = packageinfo.PackageInfoManager(scopedConfig.get("pypi_api"))
+	package_info_manager = packageinfo.PackageInfoManager(
+		scopedConfig.get("pypi_api", "https://pypi.org")
+	)
 
 	incompatible, depsWithLicenses = checker.check(
 		requirements_paths=set(requirements_paths),

licensecheck/license_matrix/__init__.py

@@ -100,11 +100,11 @@
 }
 
 termToLicense: dict[str, License] = dict(
-    sorted(
-        termToLicenseData.items(),
-        key=lambda item: len(item[0]),
-        reverse=True,
-    )
+	sorted(
+		termToLicenseData.items(),
+		key=lambda item: len(item[0]),
+		reverse=True,
+	)
 )
 
 

tests/platform_independent/test_license_matrix.py

@@ -26,9 +26,9 @@ def test_licenseLookup() -> None:
 	msgs = []
 	for x in types.License._member_names_:
 		if x not in licenses:
-			msgs.append( f"{x} not in licenses")
+			msgs.append(f"{x} not in licenses")
 
-	if len(msgs):
+	if msgs:
 		logger.error(msgs)
 		raise AssertionError(msgs)