fixed grid alignment#19
Open
Dishebh wants to merge 1 commit into
Open
Conversation
mariobehling
requested changes
Dec 22, 2019
mariobehling
left a comment
mariobehling
left a comment
Contributor
There was a problem hiding this comment.
Preview Link not working.
Contributor
Author
|
@mariobehling here's the preview link: |
mariobehling
requested changes
Dec 23, 2019
mariobehling
left a comment
mariobehling
left a comment
Contributor
There was a problem hiding this comment.
Changes result in increased white area. Unused white space in some rows now.
Contributor
Author
|
@mariobehling what about now? |
Contributor
|
Does not look like the right approach. I think we can just shorten the text. I will work on this in a bit. |
Contributor
Author
|
Cool, just let me know if I can help somehow, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes done in this Pull Request
Description / Changes
Fixed the page responsiveness issue by aligning each card a specific a height.
Screenshots if any:
Before:
After: