Merge pull request #161 from mvanhorn/refactor/metadataTarget-consistent-79

refactor(middleware): use metadataTarget consistently in class decorator branches

Author: VikramAditya33

src/websocket/middleware/filters/use-filters.decorator.ts

@@ -38,10 +38,11 @@ export function UseFilters(
     propertyKey?: string | symbol,
     descriptor?: PropertyDescriptor
   ): void | PropertyDescriptor => {
+    // For static methods, target is the constructor itself; for instance methods, it's the prototype
+    const metadataTarget = typeof target === 'function' ? target : (target as object).constructor;
+
     if (propertyKey) {
       // Method decorator - merge with existing filters and deduplicate
-      // For static methods, target is the constructor itself; for instance methods, it's the prototype
-      const metadataTarget = typeof target === 'function' ? target : (target as object).constructor;
       const existingFilters: (Type<ExceptionFilter> | ExceptionFilter)[] =
         Reflect.getMetadata(EXCEPTION_FILTERS_METADATA, metadataTarget, propertyKey) || [];
 
@@ -55,12 +56,12 @@ export function UseFilters(
     } else {
       // Class decorator - merge with existing filters and deduplicate
       const existingFilters: (Type<ExceptionFilter> | ExceptionFilter)[] =
-        Reflect.getMetadata(EXCEPTION_FILTERS_METADATA, target) || [];
+        Reflect.getMetadata(EXCEPTION_FILTERS_METADATA, metadataTarget) || [];
 
       Reflect.defineMetadata(
         EXCEPTION_FILTERS_METADATA,
         [...new Set([...existingFilters, ...filters])],
-        target
+        metadataTarget
       );
       return;
     }

src/websocket/middleware/guards/use-guards.decorator.ts

@@ -38,10 +38,11 @@ export function UseGuards(
     propertyKey?: string | symbol,
     descriptor?: PropertyDescriptor
   ): void | PropertyDescriptor => {
+    // For static methods, target is the constructor itself; for instance methods, it's the prototype
+    const metadataTarget = typeof target === 'function' ? target : (target as object).constructor;
+
     if (propertyKey) {
       // Method decorator - merge with existing guards and deduplicate
-      // For static methods, target is the constructor itself; for instance methods, it's the prototype
-      const metadataTarget = typeof target === 'function' ? target : (target as object).constructor;
       const existingGuards: (Type<CanActivate> | CanActivate)[] =
         Reflect.getMetadata(GUARDS_METADATA, metadataTarget, propertyKey) || [];
 
@@ -55,9 +56,13 @@ export function UseGuards(
     } else {
       // Class decorator - merge with existing guards and deduplicate
       const existingGuards: (Type<CanActivate> | CanActivate)[] =
-        Reflect.getMetadata(GUARDS_METADATA, target) || [];
+        Reflect.getMetadata(GUARDS_METADATA, metadataTarget) || [];
 
-      Reflect.defineMetadata(GUARDS_METADATA, [...new Set([...existingGuards, ...guards])], target);
+      Reflect.defineMetadata(
+        GUARDS_METADATA,
+        [...new Set([...existingGuards, ...guards])],
+        metadataTarget
+      );
       return;
     }
   };

src/websocket/middleware/pipes/use-pipes.decorator.ts

@@ -78,9 +78,13 @@ export function UsePipes(
     } else {
       // Class decorator - merge with existing pipes and deduplicate
       const existingPipes: (Type<PipeTransform> | PipeTransform)[] =
-        Reflect.getMetadata(PIPES_METADATA, target) || [];
+        Reflect.getMetadata(PIPES_METADATA, metadataTarget) || [];
 
-      Reflect.defineMetadata(PIPES_METADATA, [...new Set([...existingPipes, ...pipes])], target);
+      Reflect.defineMetadata(
+        PIPES_METADATA,
+        [...new Set([...existingPipes, ...pipes])],
+        metadataTarget
+      );
     }
   };