review code

Author: FRACerqueira

src/Core/UtilExtension.cs

@@ -138,7 +138,7 @@ private static bool IsGlyphInSupportedRange(char glyph)
         /// <summary>
         /// ellipsis character.
         /// </summary>
-        public static char Ellipsis = IsGlyphInSupportedRange('…') ? '…' : '.';
+        public static readonly char Ellipsis = IsGlyphInSupportedRange('…') ? '…' : '.';
 
 
         /// <summary>
@@ -267,22 +267,22 @@ public static Segment[] ToSegment(this string? text, Style defaultstyletext, ICo
                                 color = ParseHexColor(part);
                                 if (color == null)
                                 {
-                                    return [new Segment(text ?? string.Empty, defaultstyletext)];
+                                    return [new Segment(text , defaultstyletext)];
                                 }
                             }
                             else if (part.StartsWith("rgb", StringComparison.OrdinalIgnoreCase))
                             {
                                 color = ParseRgbColor(part);
                                 if (color == null)
                                 {
-                                    return [new Segment(text ?? string.Empty, defaultstyletext)];
+                                    return [new Segment(text, defaultstyletext)];
                                 }
                             }
                             else
                             {
                                 if (!first)
                                 {
-                                    return [new Segment(text ?? string.Empty, defaultstyletext)];
+                                    return [new Segment(text , defaultstyletext)];
                                 }
                                 notfound = true;
                                 token = new MarkupToken(MarkupTokenKind.Text, $"[{token.Value}]", token.Position);
@@ -311,7 +311,7 @@ public static Segment[] ToSegment(this string? text, Style defaultstyletext, ICo
                     onlytext = false;
                     if (stack.Count == 0)
                     {
-                        return [new Segment(text ?? string.Empty, defaultstyletext)];
+                        return [new Segment(text , defaultstyletext)];
                     }
                     Style oldstyle = stack.Pop();
                     if (stack.Count == 1)
@@ -323,7 +323,7 @@ public static Segment[] ToSegment(this string? text, Style defaultstyletext, ICo
                     {
                         if (stack.Count == 0 && result.Count == 0)
                         {
-                            return [new Segment(text ?? string.Empty, defaultstyletext)];
+                            return [new Segment(text, defaultstyletext)];
                         }
                         if (stack.Count > 0)
                         {
@@ -349,7 +349,7 @@ public static Segment[] ToSegment(this string? text, Style defaultstyletext, ICo
                 }
                 else
                 {
-                    return [new Segment(text ?? string.Empty, defaultstyletext)];
+                    return [new Segment(text, defaultstyletext)];
                 }
             }
             return [.. result];