feat: add nameOverride, podAnnotations, and terminationGracePeriodSeconds#12
Merged
Merged
Conversation
…onds
- Add nameOverride and fullnameOverride to values.yaml
- Add podAnnotations: {} to values.yaml
- Inject terminationGracePeriodSeconds into deployment, worker, cron, and job pod specs
- Inject podAnnotations into cron pod template (deployment/worker/job already wired)
- Update values.schema.json with all three new fields
- Add podAnnotations and terminationGracePeriodSeconds tests
FabienPapet
force-pushed
the
feat/nameoverride-podannotations
branch
from
b4f6714 to
62a3400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nameOverridefor customizing resource name prefixpodAnnotationsfor arbitrary pod-level annotationsterminationGracePeriodSecondsconfigurationTest results
make lint: PASSmake unit-test: 21 suites, 135 tests — all PASSmake validate: all 14 example files valid (kubeconform k8s 1.29)Notes
Stacked on:
fix/podmonitor-service-bugs🤖 Generated with Claude Code