Add fabric:false resource condition#5410
Open
cassiancc wants to merge 1 commit into
Open
Conversation
modmuss50
approved these changes
Jun 1, 2026
modmuss50
added
the
status: last call
CelDaemon
reviewed
Jun 1, 2026
| @Test | ||
| public void logics() { | ||
| ResourceCondition alwaysTrue = ResourceConditions.alwaysTrue(); | ||
| ResourceCondition alwaysFalse = ResourceConditions.not(alwaysTrue); |
Contributor
There was a problem hiding this comment.
Should there be a separate test for not?
Member
Author
There was a problem hiding this comment.
It is still used in DataGeneratorTestEntrypoint, if it's needed elsewhere suggestions are welcome, I'm not too familiar with gametests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an equivalent to
fabric:truethat never passes, useful for quickly unloading resources like unwanted recipes or advancements. This is already possible by chainingfabric:notwithfabric:true, but that is quite longwinded when manually updating JSON (e.g. modpacks), and having an obviousfalseis preferred. Uses offabric:notwhen applied tofabric:truein data generation tests have been updated to usefabric:false.