Skip to content

Expose registries in EnchantmentEvents.MODIFY#5415

Open
Maganoos wants to merge 6 commits into
FabricMC:26.2from
Maganoos:feat/registryaccess
Open

Expose registries in EnchantmentEvents.MODIFY#5415
Maganoos wants to merge 6 commits into
FabricMC:26.2from
Maganoos:feat/registryaccess

Conversation

@Maganoos
Copy link
Copy Markdown

@Maganoos Maganoos commented Jun 4, 2026

(resolves #5020)

@Patbox Patbox added the enhancement New feature or request label Jun 4, 2026
@Maganoos Maganoos changed the title Expose registries in EnchantmentEvents.MODIFY (resolves #5020) Expose registries in EnchantmentEvents.MODIFY Jun 4, 2026
@Maganoos Maganoos requested a review from Patbox June 5, 2026 15:48
public static final Event<Modify> MODIFY = EventFactory.createArrayBacked(
Modify.class,
@Deprecated(forRemoval = true)
public static final Event<ModifyNoRegistries> MODIFY = EventFactory.createArrayBacked(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still an api breakage

Copy link
Copy Markdown
Author

@Maganoos Maganoos Jun 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still? Was it because the interface name was changed?

@Maganoos Maganoos requested a review from Patbox June 5, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EnchantmentEvents.MODIFY doesn't provide any way to access registries

2 participants