Connect to Sales model, export TMDL, document improvements, add PBIP .gitignore

[Copilot]

Connected to the Sales semantic model in the Git Demo Fabric workspace, performed a full model review, and captured all artefacts in source control.

Table row counts (at time of review)

Table	Rows
Calendar	1,461
Customer	5,585
Product	2,517
Sales	2,881
Store	74
About / Smart Calcs / Parameter tables	3–6

Changes

• items/Sales.SemanticModel/ — Full TMDL export (19 files) organised into tables/, roles/, cultures/, and perspectives/ sub-folders via ExportToTmdlFolder.

• issues/sales-model-improvements.md — 18 improvement suggestions across:

  • Naming: double-space typos in Sales Amount (Δ LY) / Sales Amount (% Δ LY)
  • Formatting: inconsistent currency and percentage format strings; ROUND() baked into Margin % Overall instead of using a format string
  • Documentation: ~25 of 29 measures have no description; no model-level description; no display folders
  • DAX quality: opaque numeric SWITCH codes in Dynamic Measure.Value; commented-out dead code in Value Normalized (by date); Sales Qty uses lowercase sum() while all other additive measures use SUMX
  • Modelling: Calendar not marked as a Date Table; forceUniqueNames disabled; Customer[Age] may go stale (should derive from Birthday); undocumented Sales[Environment] and Sales[Time] columns
  • Security: RLS roles hardcode store codes — fragile against data changes

• .gitignore — PBIP-aware gitignore covering Desktop cache files (cache.abf, localSettings.json), compiled blobs (.pbix, .pbit), and standard OS/IDE noise.