fix(datastore): make restore_config optional() to match x-ui-overrides-only (#367)

Several datastore modules marked restore_config x-ui-overrides-only in
facets.yaml (not a primary spec field) but declared it as a non-optional
attribute in variables.tf. A spec that omitted restore_config passed schema
validation, then failed terraform plan with
`attribute "restore_config" is required` — no signal until plan time.

Wrap restore_config in optional(...) with a safe default (restore_from_backup
= false; {} for the all-optional azure mysql block) so the un-set case just
works. Existing validations already short-circuit on the no-restore path, so
behavior is unchanged when the block is provided.

Modules fixed: mysql/aws-rds, postgres/aws-rds, mysql/gcp-cloudsql,
postgres/gcp-cloudsql, mysql/flexible_server, redis/gcp-memorystore.
(imports was already optional everywhere; azure postgres + aws redis already
clean.)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: unni-facets <krishnanunni.menon@facets.cloud>

Author: 3 people

modules/datastore/mysql/aws-rds/1.0/variables.tf

@@ -17,12 +17,12 @@ variable "instance" {
         storage_type          = string
         read_replica_count    = number
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup           = bool
         source_db_instance_identifier = optional(string)
         restore_master_username       = optional(string)
         restore_master_password       = optional(string)
-      })
+      }), { restore_from_backup = false })
       imports = optional(object({
         import_existing        = optional(bool, false)
         db_instance_identifier = optional(string)

modules/datastore/mysql/flexible_server/1.0/variables.tf

@@ -18,13 +18,13 @@ variable "instance" {
         storage_tier       = string
         read_replica_count = number
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup    = optional(bool)
         source_server_id       = optional(string)
         restore_point_in_time  = optional(string)
         administrator_login    = optional(string)
         administrator_password = optional(string)
-      })
+      }), {})
       imports = optional(object({
         import_existing  = optional(bool, false)
         server_id        = optional(string)

modules/datastore/mysql/gcp-cloudsql/1.0/variables.tf

@@ -14,12 +14,12 @@ variable "instance" {
         disk_size          = number
         read_replica_count = number
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup = bool
         source_instance_id  = optional(string)
         master_username     = optional(string)
         master_password     = optional(string)
-      })
+      }), { restore_from_backup = false })
       imports = optional(object({
         import_existing = optional(bool, false)
         instance_name   = optional(string)

modules/datastore/postgres/aws-rds/1.0/variables.tf

@@ -17,12 +17,12 @@ variable "instance" {
       security_config = object({
         deletion_protection = bool
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup           = bool
         source_db_instance_identifier = optional(string)
         master_username               = optional(string)
         master_password               = optional(string)
-      })
+      }), { restore_from_backup = false })
       imports = optional(object({
         import_existing        = optional(bool, false)
         db_instance_identifier = optional(string)

modules/datastore/postgres/gcp-cloudsql/1.0/variables.tf

@@ -14,12 +14,12 @@ variable "instance" {
         disk_size          = number
         read_replica_count = number
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup = bool
         source_instance_id  = optional(string)
         master_username     = optional(string)
         master_password     = optional(string)
-      })
+      }), { restore_from_backup = false })
       network_config = optional(object({
         ipv4_enabled = optional(bool, false)
         require_ssl  = optional(bool, true)

modules/datastore/redis/gcp-memorystore/1.0/variables.tf

@@ -15,10 +15,10 @@ variable "instance" {
         memory_size_gb = number
         tier           = string
       })
-      restore_config = object({
+      restore_config = optional(object({
         restore_from_backup = bool
         source_instance_id  = optional(string)
-      })
+      }), { restore_from_backup = false })
       security = object({
         enable_tls = bool
       })