fix(datastore/mysql/aws-rds): drop dead master_username spec field#364
Open
srikxcipher wants to merge 1 commit into
Open
fix(datastore/mysql/aws-rds): drop dead master_username spec field#364srikxcipher wants to merge 1 commit into
srikxcipher wants to merge 1 commit into
Conversation
master_username was never wired from spec — locals.tf derives it ("admin"
for new instances, restore_master_username for restores), so exposing it in
version_config was dead and misleading. Remove the field and its validation.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
master_usernamefield (and its length validation) from the user-facingversion_configspec of the MySQL AWS-RDS module.Why
master_usernamewas never wired to the resource from spec —locals.tfalready derives it:"admin"for new instances, orrestore_master_usernamefor restore operations. Exposing it inversion_configwas dead and misleading: setting it had no effect.Changes
variables.tf: dropmaster_usernamefromversion_configobject and remove its 1–16 char validation block.facets.yaml(spec, x-ui-order, sample) already contained nomaster_usernameunderversion_config, so no schema change was needed.Validation
version_config.master_usernamein the module.restore_master_username) untouched.🤖 Generated with Claude Code