fix(datastore/postgres/gcp-cloudsql): read project_id, not project - #366
Merged
Conversation
The three GCP datastore modules consume the same @facets/gcp_cloud_account provider input, but postgres/gcp-cloudsql declared the attribute as `project` while mysql/gcp-cloudsql and redis/gcp-memorystore use `project_id`. Both work today only because the resource-type system passes the whole interface object; the drift breaks the moment the output schema is tightened to one canonical name. Align on project_id (matches the two siblings and GCP API naming). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
unni-facets
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames the
gcp_provider.attributesfield read bypostgres/gcp-cloudsqlfromprojecttoproject_id.Why
All three GCP datastore modules consume the same
@facets/gcp_cloud_accountprovider input, but read different attribute names:mysql/gcp-cloudsqlproject_idredis/gcp-memorystoreproject_idpostgres/gcp-cloudsqlproject← driftedBoth names resolve today only because the resource-type system passes the whole
@facets/gcp_cloud_accountinterface object through. The inconsistency breaks the moment the output schema is tightened to require one canonical name.project_idmatches the two siblings and standard GCP API parameter naming.Changes
variables.tf:project→project_idin thegcp_providerinput type. Non-behavioral — the attribute isn't read in.tfcode; this just makes the declared input shape consistent across siblings.Verified: no GCP datastore module reads
attributes.project(non-_id) anywhere.Follow-up (out of scope)
If
@facets/gcp_cloud_accountexposes bothprojectandproject_idas a back-compat artifact, dropprojectfrom the output type once no module reads it.🤖 Generated with Claude Code