refactor: consolidate DNS-01 and ACK ACM helm releases into utility module

[sanmesh-kakade]

Summary

• Consolidated DNS-01 and ACK ACM helm release resources from cloud-specific legacy modules (AWS, Azure, GCP) into the shared utility module
• Reduces duplication across 3 cloud providers by moving helm release logic to a single location
• Cherry-picked from develop (squash merge refactor: consolidate DNS-01 and ACK ACM helm releases into utility module #535)

Test plan

• Verify DNS-01 certificate issuance still works on AWS/Azure/GCP
• Verify ACK ACM certificate integration still works on AWS
• Confirm helm releases are created correctly by the utility module

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor
  • Consolidated certificate resource management across AWS, Azure, and GCP ingress modules
  • Certificate resources (ACM and DNS-01) now provisioned through unified base module extension rather than separate module declarations
  • Improves code organization and maintainability while preserving existing functionality across all cloud providers

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 290b9cf5-d29b-41a2-af81-f4d1bb5cb38b

📥 Commits

Reviewing files that changed from the base of the PR and between e523d41 and b23bac8.

📒 Files selected for processing (3)

• modules/ingress/nginx_gateway_fabric_legacy_aws/1.0/main.tf
• modules/ingress/nginx_gateway_fabric_legacy_azure/1.0/main.tf
• modules/ingress/nginx_gateway_fabric_legacy_gcp/1.0/main.tf

---

Walkthrough

Three legacy nginx gateway fabric Terraform modules refactored to pass certificate resources to the base module via an additional_base_resources input parameter, replacing previous standalone module declarations. The changes consolidate ACM (AWS-only) and DNS-01 certificate resource creation into locally-computed maps integrated into the shared base module architecture.

Changes

Cohort / File(s)

Summary

Certificate Resource Consolidation modules/ingress/nginx_gateway_fabric_legacy_aws/1.0/main.tf, modules/ingress/nginx_gateway_fabric_legacy_azure/1.0/main.tf, modules/ingress/nginx_gateway_fabric_legacy_gcp/1.0/main.tf

Introduced local maps (ack_acm_resources for AWS only, dns01_certificate_resources for all) containing cert-manager and ACK CRD specifications. Wired these maps into module "nginx_gateway_fabric" via new additional_base_resources input. Removed standalone module "ack_acm_certificate" (AWS only) and module "dns01_certificate" blocks, shifting certificate resource creation into the base module's extension mechanism.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch consolidate-helm-releases-master

📝 Coding Plan

• Generate coding plan for human review comments

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Trivy (0.69.3)

Trivy execution failed: Unknown error

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}