fix: update ack_acm_controller output schema format

[rauneetverma]

Description

Related issues

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• I have created feat/bugfix branch out of develop branch
• Code passes linting/formatting checks
• Changes to resources have been tested in our dev environments
• I have made corresponding changes to the documentation

Testing

Reviewer instructions

Summary by CodeRabbit

• Chores
  • Updated output configuration schema structure for ACK ACM controller, with enforced required fields (namespace, release name, chart version, role ARN, and Helm release ID) to improve data consistency and validation.

[sanmesh-kakade]

LGTM, this was miss from my side, had schema from facets modules redesign.

[coderabbitai]

Walkthrough

The ACK ACM controller output facet schema is restructured with a new out object structure, renamed identifier, and explicit required: true markers for specific attributes. The interfaces and providers sections are removed.

Changes

Cohort / File(s)	Summary
ACK ACM Controller Output Facet outputs/ack_acm_controller/output.facets.yaml	Schema restructured: top-level properties replaced with out object; name identifier changed from @outputs/ack_acm_controller to ack_acm_controller; namespace, release_name, chart_version, role_arn, and helm_release_id attributes marked as required: true; interfaces and providers sections removed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description consists only of template comments and unchecked checkboxes with no actual content, context, or implementation details provided.	Fill in the description with a summary of changes, explain the motivation/context, mark the appropriate type of change, and provide testing details and reviewer instructions.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: updating the ack_acm_controller output schema format.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-output-schema

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 0/1 reviews remaining, refill in 60 minutes.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@outputs/ack_acm_controller/output.facets.yaml`:
- Line 28: The YAML contains a null node for the key "interfaces" which can
break downstream parsing; update the "interfaces:" entry in output.facets.yaml
(the explicit "interfaces" key) to either be removed or set to an explicit empty
mapping (interfaces: {}) so it serializes as an object instead of null; make
this change where "interfaces:" appears to ensure consumers expecting a map
receive an empty object.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bea057ca-3aed-4d4f-a60d-e998e2e6c35f

📥 Commits

Reviewing files that changed from the base of the PR and between ceacb93 and 5fe8d4a.

📒 Files selected for processing (1)

• outputs/ack_acm_controller/output.facets.yaml

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Avoid leaving interfaces as a null node.

At Line 28, interfaces: has no value, which serializes to null. If downstream expects an object/map, this can cause validation/parsing issues. Prefer removing it or making it an explicit empty object.

Suggested patch

-    interfaces:
+    interfaces: {}

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	interfaces:
	interfaces: {}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@outputs/ack_acm_controller/output.facets.yaml` at line 28, The YAML contains
a null node for the key "interfaces" which can break downstream parsing; update
the "interfaces:" entry in output.facets.yaml (the explicit "interfaces" key) to
either be removed or set to an explicit empty mapping (interfaces: {}) so it
serializes as an object instead of null; make this change where "interfaces:"
appears to ensure consumers expecting a map receive an empty object.