Skip to content

fix: update ack_acm_controller output schema format #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanmesh-kakade merged 1 commit into from
Apr 29, 2026
Merged

fix: update ack_acm_controller output schema format #545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 24 additions & 22 deletions outputs/ack_acm_controller/output.facets.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,28 @@
name: '@outputs/ack_acm_controller'
properties:
name: ack_acm_controller
out:
type: object
title: ACK ACM Controller
description: ACK ACM Controller Attributes
properties:
attributes:
type: object
properties:
namespace:
description: Kubernetes namespace where the controller is deployed
type: string
release_name:
description: Helm release name
type: string
chart_version:
description: Helm chart version
type: string
role_arn:
description: IAM role ARN used by the controller
type: string
helm_release_id:
description: Helm release ID
type: string
namespace:
required: true
type: string
description: Kubernetes namespace where the controller is deployed
release_name:
required: true
type: string
description: Helm release name
chart_version:
required: true
type: string
description: Helm chart version
role_arn:
required: true
type: string
description: IAM role ARN used by the controller
helm_release_id:
required: true
type: string
description: Helm release ID
interfaces:

@coderabbitai coderabbitai Bot Apr 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Avoid leaving interfaces as a null node.

At Line 28, interfaces: has no value, which serializes to null. If downstream expects an object/map, this can cause validation/parsing issues. Prefer removing it or making it an explicit empty object.

Suggested patch 
-    interfaces:
+    interfaces: {}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
interfaces:
interfaces: {}
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@outputs/ack_acm_controller/output.facets.yaml` at line 28, The YAML contains
a null node for the key "interfaces" which can break downstream parsing; update
the "interfaces:" entry in output.facets.yaml (the explicit "interfaces" key) to
either be removed or set to an explicit empty mapping (interfaces: {}) so it
serializes as an object instead of null; make this change where "interfaces:"
appears to ensure consumers expecting a map receive an empty object.

type: object
properties: {}
providers: []
Loading