fix initalDelaySeonds for deploy/sts#546
Merged
Merged
Conversation
rauneetverma
requested review from
anshulsao,
ishaankalra,
pramodh-ayyappan,
rr0hit,
unni-facets and
vishnukv-facets
as code owners
April 30, 2026 04:55
Contributor
WalkthroughThe health-check schema for startup timing is updated across deployment modules by renaming Changes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
modules/service/statefulset/0.1/facets.yaml (1)
412-419:⚠️ Potential issue | 🟠 Major | ⚡ Quick winUnify startup delay key naming across main runtime and sidecars
Line 412 introduces
startup_initial_delay_seconds, but sidecars still usestartup_start_up_timeat Line 1701. This creates two keys for the same concept in one schema. Also, title/placeholder text still says “Start-Up Time”, which no longer matches the key semantics.🔧 Proposed fix
- startup_initial_delay_seconds: + startup_initial_delay_seconds: type: integer - title: Startup Start-Up Time + title: Startup Initial Delay Seconds default: 10 minimum: 0 maximum: 10000 - x-ui-placeholder: Enter startup start up time for the Pod + x-ui-placeholder: Enter startup initial delay in seconds for the Pod x-ui-error-message: Value doesn't match pattern, accepted values are from 0-10000 @@ - startup_start_up_time: + startup_initial_delay_seconds: type: integer - title: Startup Start-Up Time + title: Startup Initial Delay Seconds default: 10 minimum: 0 maximum: 10000 - x-ui-placeholder: Enter startup start up time for the Pod + x-ui-placeholder: Enter startup initial delay in seconds for the PodAlso applies to: 1701-1708
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@modules/service/statefulset/0.1/facets.yaml` around lines 412 - 419, Replace the duplicate keys by unifying the schema to use a single, consistent property name (choose and standardize on either startup_initial_delay_seconds or startup_start_up_time) across the main runtime and all sidecar definitions (references: startup_initial_delay_seconds and startup_start_up_time), and update the title, x-ui-placeholder and x-ui-error-message values to reflect the chosen semantics (e.g., "Startup initial delay (seconds)" and "Enter startup initial delay in seconds") so the key name, title and placeholders are consistent across the schema.modules/service/deployment/0.1/facets.yaml (1)
422-429:⚠️ Potential issue | 🟠 Major | ⚡ Quick winApply the same startup delay rename in sidecars and UI labels
Line 422 renames the main runtime field to
startup_initial_delay_seconds, but sidecars still exposestartup_start_up_time(Line 1666). The title/placeholder also still describe “Start-Up Time” instead of initial delay seconds.🔧 Proposed fix
startup_initial_delay_seconds: type: integer - title: Startup Start-Up Time + title: Startup Initial Delay Seconds default: 10 minimum: 0 maximum: 10000 - x-ui-placeholder: "Enter startup start up time for the Pod" + x-ui-placeholder: "Enter startup initial delay in seconds for the Pod" @@ - startup_start_up_time: + startup_initial_delay_seconds: type: integer - title: Startup Start-Up Time + title: Startup Initial Delay Seconds default: 10 minimum: 0 maximum: 10000 - x-ui-placeholder: "Enter startup start up time for the Pod" + x-ui-placeholder: "Enter startup initial delay in seconds for the Pod"Also applies to: 1666-1673
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@modules/service/deployment/0.1/facets.yaml` around lines 422 - 429, The sidecar and UI labels are inconsistent with the renamed main field: change any occurrences of startup_start_up_time (sidecars) to startup_initial_delay_seconds so the schema key matches the main runtime field (startup_initial_delay_seconds), and update the title, x-ui-placeholder and x-ui-error-message values for both the main and sidecar entries to reference "Startup initial delay seconds" (or similar phrasing) instead of "Start-Up Time"/"start up time" so the label and placeholder accurately describe initial delay seconds across the file; ensure both schema properties and their UI metadata (title, x-ui-placeholder, x-ui-error-message) are updated for the sidecar block that currently uses startup_start_up_time and the main block using startup_initial_delay_seconds.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@modules/service/deployment/0.1/facets.yaml`:
- Around line 422-429: The sidecar and UI labels are inconsistent with the
renamed main field: change any occurrences of startup_start_up_time (sidecars)
to startup_initial_delay_seconds so the schema key matches the main runtime
field (startup_initial_delay_seconds), and update the title, x-ui-placeholder
and x-ui-error-message values for both the main and sidecar entries to reference
"Startup initial delay seconds" (or similar phrasing) instead of "Start-Up
Time"/"start up time" so the label and placeholder accurately describe initial
delay seconds across the file; ensure both schema properties and their UI
metadata (title, x-ui-placeholder, x-ui-error-message) are updated for the
sidecar block that currently uses startup_start_up_time and the main block using
startup_initial_delay_seconds.
In `@modules/service/statefulset/0.1/facets.yaml`:
- Around line 412-419: Replace the duplicate keys by unifying the schema to use
a single, consistent property name (choose and standardize on either
startup_initial_delay_seconds or startup_start_up_time) across the main runtime
and all sidecar definitions (references: startup_initial_delay_seconds and
startup_start_up_time), and update the title, x-ui-placeholder and
x-ui-error-message values to reflect the chosen semantics (e.g., "Startup
initial delay (seconds)" and "Enter startup initial delay in seconds") so the
key name, title and placeholders are consistent across the schema.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: ad9f4547-af29-4d22-833e-fc74fd720176
📒 Files selected for processing (2)
modules/service/deployment/0.1/facets.yamlmodules/service/statefulset/0.1/facets.yaml
mbhandari31
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect schema field name for startup probe's initialDelaySeconds in facets.yaml. Changed
startup_start_up_time to startup_initial_delay_seconds to match what the Helm template (_helpers.tpl) actually reads.
Context
The Helm template at _helpers.tpl:320 reads:
{{ default .Values.spec.runtime.health_checks.start_up_time
.Values.spec.runtime.health_checks.startup_initial_delay_seconds | default 10 }}
The facets.yaml schema was defining the field as startup_start_up_time, which is not consumed by the template.
This caused any value set via the UI form to be silently ignored, and the startup probe would always fall
back to the default of 10.
Any service that configured startup_start_up_time via the form was not getting the correct initialDelaySeconds
value applied to the startup probe — unless they also happened to set startup_initial_delay_seconds directly
in JSON mode.
Related issues
Type of change
Checklist
developbranchTesting
Reviewer instructions