feat(aws_eks): expose facets_dedicated min_nodes in spec

[sanmesh-kakade]

What

Adds a min_nodes field to the facets_dedicated nodepool spec in kubernetes_cluster/aws_eks/0.2 (default 1).

Why

The dedicated managed node group hosts Karpenter and the platform/monitoring singletons. Its min_size/desired_size were hardcoded to 1, making a single dedicated node a SPOF. Exposing min_nodes lets clusters run the dedicated node group with ≥2 nodes (across AZs) for HA.

Pairs with

facets-cloud/facets-iac PR #2134, which threads spec.nodepools.facets_dedicated.min_nodes into the managed node group's min_size/desired_size (defaulting to 1, backward compatible).

Compatibility

default: 1 — no behaviour change for existing clusters. Set min_nodes: 2 for HA.

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features
  • Added configurable minimum node count for dedicated EKS node pools.
  • Added a configurable desired node count for dedicated node pools, applied at creation time.
  • Both settings are shown in the interface only when dedicated node pools are enabled.
  • Updated the configuration field ordering to improve readability.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• facets-saas

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e4c6270c-1fed-4fbb-8682-7d36d3b2f9c9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Walkthrough

The EKS dedicated nodepool schema adds conditional min_nodes and desired_nodes fields with integer constraints, defaults, and UI ordering between max_nodes and AMI-related fields.

Changes

EKS dedicated nodepool configuration

Layer / File(s)	Summary
Dedicated nodepool node count configuration modules/kubernetes_cluster/aws_eks/0.2/facets.yaml	Adds min_nodes and desired_nodes with validation, defaults, conditional visibility, and updated UI field ordering.

Suggested reviewers: anshulsao, ishaankalra, pramodh-ayyappan, rr0hit, unni-facets

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title accurately summarizes the main change by exposing min_nodes for the facets_dedicated AWS EKS spec.
Description check	✅ Passed	It clearly explains the change, motivation, dependency, and compatibility, though it does not fully match the repository template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/facets-dedicated-min-nodes

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@modules/kubernetes_cluster/aws_eks/0.2/facets.yaml`:
- Around line 208-220: Update the node pool facet validation around min_nodes
and max_nodes to enforce min_nodes <= max_nodes before managed node group sizing
uses the values. Add cross-field schema validation or equivalent downstream
validation while preserving the existing 1..200 bounds and defaults.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af1f0048-8347-4111-845d-c42099bbc0a0

📥 Commits

Reviewing files that changed from the base of the PR and between 5962c23 and c2fa679.

📒 Files selected for processing (1)

• modules/kubernetes_cluster/aws_eks/0.2/facets.yaml

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@modules/kubernetes_cluster/aws_eks/0.2/facets.yaml`:
- Around line 221-228: Update the desired_nodes schema entry in the facets
definition to enforce its relationship with min_nodes and max_nodes, rejecting
values below min_nodes or above max_nodes while retaining the existing 1..200
bounds; if the schema cannot express this cross-field validation, remove the
bounded-to-Min/Max promise from the description.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3cf43aa2-6b60-4965-8f98-446ca634221f

📥 Commits

Reviewing files that changed from the base of the PR and between c2fa679 and 9a1b2cc.

📒 Files selected for processing (1)

• modules/kubernetes_cluster/aws_eks/0.2/facets.yaml