fix: stop tests leaking skill dirs into cmd/, drop the gitignore band-aid (#45)

Two cmd/* tests installed skills into harnesses with no SkillDir, so the
install path resolved relative to the test CWD and littered the repo with
`cmd/praxis*/` skill dirs. The leak was masked by a `/cmd/praxis*/`
.gitignore rule rather than fixed.

- TestInstallSkill_Success: didn't isolate HOME or stub the catalog fetch,
  so after the (seamed) meta-skill install the real catalog flow ran
  against the developer's live profile and installed real catalog skills
  into the SkillDir-less harnesses. Isolate HOME + clear PRAXIS_PROFILE so
  the catalog step soft-skips (matches sibling tests).
- TestRunPostAuthSetupAgentFetchFailureLeavesExistingInPlace: set AgentDir
  but no SkillDir, so runPostAuthSetup's meta-skill install (praxis,
  praxis-memory, praxis-onboarding) landed in CWD. Point SkillDir under the
  test's tmp HOME.
- .gitignore: drop the now-obsolete /cmd/praxis/ and /cmd/praxis-*/ rules
  (and the explanatory comment) — with the leaks fixed, a future leak will
  correctly surface in `git status` instead of being silently hidden.

Verified: `go test -race ./...` is green and leaves no cmd/praxis* dirs.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: anujhydrabadi

.gitignore

@@ -7,14 +7,6 @@
 *.exe
 coverage.txt
 
-# Pre-existing test leak: some cmd/* test writes catalog skill files
-# relative to its CWD instead of to t.TempDir(), polluting the repo
-# tree with /cmd/praxis*/ folders containing real-looking SKILL.md
-# contents. Until that test is fixed, ignore the leak so it doesn't
-# litter `git status` on every test run.
-/cmd/praxis/
-/cmd/praxis-*/
-
 # goreleaser output
 /dist/
 

cmd/login_setup_test.go

@@ -296,6 +296,10 @@ func TestRunPostAuthSetupAgentFetchFailureLeavesExistingInPlace(t *testing.T) {
 	hosts := []harness.Harness{{
 		Name:     "claude-code",
 		Detected: true,
+		// SkillDir must point under tmp: runPostAuthSetup installs the
+		// meta-skills before the agent step, and a host without a SkillDir
+		// resolves to a CWD-relative path, leaking praxis* skill dirs into cmd/.
+		SkillDir: filepath.Join(tmp, "claude", "skills"),
 		AgentDir: filepath.Join(tmp, "claude", "agents"),
 	}}
 

cmd/skill_test.go

@@ -90,6 +90,13 @@ func TestInstallSkill_NoHosts(t *testing.T) {
 }
 
 func TestInstallSkill_Success(t *testing.T) {
+	// Isolate HOME so the catalog step resolves a not-logged-in profile and
+	// soft-skips. Without this, the real catalog flow runs against the
+	// developer's live profile and installs real catalog skills into the
+	// SkillDir-less harnesses below — which resolves to a path under the test
+	// CWD, leaking praxis-* skill dirs into cmd/ (see .gitignore history).
+	t.Setenv("HOME", t.TempDir())
+	t.Setenv("PRAXIS_PROFILE", "")
 	withSeams(t,
 		func() []harness.Harness {
 			return []harness.Harness{