Fixing Bug 345#346
Open
XeniaHerr wants to merge 1 commit into
Open
Conversation
The handleEventCreate Method is providing a default event to populate, but the decision wether to create or update a event is made by checking if event is null, which is never the case when calling from handleEventCreate. I've changed the checks to use event.title, because title is not pouplated when createing and you need a title to save. Also the way the luxon dateTime was used is not working, the methods are not inplace, fixed that also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handleEventCreate Method is providing a default event to populate, but the decision wether to create or update a event is made by checking if event is null, which is never the case when calling from handleEventCreate. I've changed the checks to use event.title, because title is not pouplated when createing and you need a title to save.
Also the way the luxon dateTime was used is not working, the methods are not inplace, fixed that also.
If you have Question we can brawl in person,