Skip to content

Commit 1c6a2a5

Browse files
feat(gitlab): expose security_block_on_critical/high inputs (A10)
Matches GitHub action's input surface for security_block_on_critical (default "true") and security_block_on_high (default "false"). Like the GitHub action, the inputs are parsed into context but not currently consumed by production code — they exist for surface-level parity and forward compatibility when blocking logic lands. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
1 parent 08f5c4c commit 1c6a2a5

1 file changed

Lines changed: 14 additions & 0 deletions

File tree

gitlab/templates/review.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,18 @@ spec:
2727
input. The security-review skill is built into the Droid CLI; no
2828
plugin install is required.
2929
default: "false"
30+
security_block_on_critical:
31+
description: |
32+
When the security reviewer reports CRITICAL findings, block merge
33+
of the MR. Mirrors the GitHub action's `security_block_on_critical`
34+
input. Defaults to `"true"`.
35+
default: "true"
36+
security_block_on_high:
37+
description: |
38+
When the security reviewer reports HIGH findings, block merge of
39+
the MR. Mirrors the GitHub action's `security_block_on_high` input.
40+
Defaults to `"false"`.
41+
default: "false"
3042
settings:
3143
description: |
3244
Droid Exec settings as a JSON string or a path to a JSON file.
@@ -67,6 +79,8 @@ droid-review:
6779
REASONING_EFFORT: "$[[ inputs.reasoning_effort ]]"
6880
INCLUDE_SUGGESTIONS: "$[[ inputs.include_suggestions ]]"
6981
AUTOMATIC_SECURITY_REVIEW: "$[[ inputs.automatic_security_review ]]"
82+
SECURITY_BLOCK_ON_CRITICAL: "$[[ inputs.security_block_on_critical ]]"
83+
SECURITY_BLOCK_ON_HIGH: "$[[ inputs.security_block_on_high ]]"
7084
DROID_SETTINGS: "$[[ inputs.settings ]]"
7185
DROID_SUCCESS: "true"
7286
before_script:

0 commit comments

Comments
 (0)