Skip to content

Commit 2b4e585

Browse files
fix: set review default model to gpt-5.3-codex and add default sync test
1 parent 432798d commit 2b4e585

4 files changed

Lines changed: 35 additions & 4 deletions

File tree

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ inputs:
9494
review_model:
9595
description: "Override the model used for code review (e.g., 'claude-sonnet-4-5-20250929', 'gpt-5.1-codex'). Only applies to review flows."
9696
required: false
97-
default: "gpt-5.2"
97+
default: "gpt-5.3-codex"
9898
reasoning_effort:
99-
description: "Override reasoning effort for review flows (passed to Droid Exec as --reasoning-effort). If empty and review_model is also empty, the action defaults internally to gpt-5.2 at high reasoning."
99+
description: "Override reasoning effort for review flows (passed to Droid Exec as --reasoning-effort). If empty and review_model is also empty, the action defaults internally to gpt-5.3-codex at high reasoning."
100100
required: false
101101
default: "high"
102102
review_use_validator:

review/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ inputs:
1515
review_model:
1616
description: "Model to use for review"
1717
required: false
18-
default: "gpt-5.2"
18+
default: "gpt-5.3-codex"
1919
reasoning_effort:
2020
description: "Reasoning effort for review (passed to Droid Exec as --reasoning-effort)"
2121
required: false

test/modes/tag/review-command.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ describe("prepareReviewMode", () => {
390390
(call: unknown[]) => call[0] === "droid_args",
391391
) as [string, string] | undefined;
392392
// When neither REVIEW_MODEL nor REASONING_EFFORT is provided, no --model or --reasoning-effort
393-
// flags are added. Defaults are handled by the action.yml inputs (gpt-5.2 / high).
393+
// flags are added. Defaults are handled by the action.yml inputs (gpt-5.3-codex / high).
394394
expect(droidArgsCall?.[1]).not.toContain("--model");
395395
expect(droidArgsCall?.[1]).not.toContain("--reasoning-effort");
396396
});
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
import { describe, expect, it } from "bun:test";
2+
import { readFileSync } from "node:fs";
3+
import { join } from "node:path";
4+
5+
function extractReviewModelDefault(yaml: string): string {
6+
const match = yaml.match(
7+
/review_model:\n(?:\s+.*\n)*?\s+default:\s*"([^"]+)"/,
8+
);
9+
10+
expect(match).toBeTruthy();
11+
return match?.[1] ?? "";
12+
}
13+
14+
describe("review_model default sync", () => {
15+
it("keeps review_model default in sync between action manifests", () => {
16+
const rootActionYaml = readFileSync(
17+
join(process.cwd(), "action.yml"),
18+
"utf8",
19+
);
20+
const reviewActionYaml = readFileSync(
21+
join(process.cwd(), "review", "action.yml"),
22+
"utf8",
23+
);
24+
25+
const rootDefault = extractReviewModelDefault(rootActionYaml);
26+
const reviewDefault = extractReviewModelDefault(reviewActionYaml);
27+
28+
expect(rootDefault).toBe(reviewDefault);
29+
expect(rootDefault.length).toBeGreaterThan(0);
30+
});
31+
});

0 commit comments

Comments
 (0)