Skip to content

Commit c71725e

Browse files
revert(gitlab): drop draft-skip rules + stderr tail-60 capture
Removes two GitLab-only behaviours that don't exist in the GitHub action: - Draft/WIP `rules: when: never` block. GitHub leaves draft handling to the user's workflow `if: ... draft == false` condition and doesn't bake it into the action. Customers who want to skip drafts can add the same condition to their own .gitlab-ci.yml. - Stderr tail-60 capture into droid-error.txt. GitHub uses core.setFailed(error.message) which surfaces in the Actions run summary, not in the PR comment body — the comment just shows an actionFailed flag. Revert to the plain "droid exec pass N failed" message for parity. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
1 parent 46be9f7 commit c71725e

1 file changed

Lines changed: 2 additions & 18 deletions

File tree

gitlab/templates/review.yml

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -45,12 +45,6 @@ droid-review:
4545
stage: $[[ inputs.stage ]]
4646
image: oven/bun:1.2.11
4747
rules:
48-
# Skip draft / WIP MRs (parity with GitHub's `if: ... draft == false`
49-
# pattern). The legacy "WIP:" prefix is also covered.
50-
- if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TITLE =~ /^Draft:/'
51-
when: never
52-
- if: '$CI_PIPELINE_SOURCE == "merge_request_event" && $CI_MERGE_REQUEST_TITLE =~ /^WIP:/'
53-
when: never
5448
- if: '$CI_PIPELINE_SOURCE == "merge_request_event"'
5549
variables:
5650
DROID_STATE_FILE: "$CI_PROJECT_DIR/.droid-state.json"
@@ -126,12 +120,7 @@ droid-review:
126120
echo "Running Pass 1 (candidates): droid $DROID_ARGS"
127121
if ! droid $DROID_ARGS 2>&1 | tee "$PASS1_LOG"; then
128122
export DROID_SUCCESS=false
129-
{
130-
echo "droid exec pass 1 (candidates) failed"
131-
echo ""
132-
echo "--- last 60 lines of pass 1 output ---"
133-
tail -n 60 "$PASS1_LOG" 2>/dev/null || true
134-
} > /tmp/droid-error.txt
123+
echo "droid exec pass 1 (candidates) failed" > /tmp/droid-error.txt
135124
exit 1
136125
fi
137126
- |
@@ -155,12 +144,7 @@ droid-review:
155144
echo "Running Pass 2 (validator): droid $DROID_ARGS"
156145
if ! droid $DROID_ARGS 2>&1 | tee "$PASS2_LOG"; then
157146
export DROID_SUCCESS=false
158-
{
159-
echo "droid exec pass 2 (validator) failed"
160-
echo ""
161-
echo "--- last 60 lines of pass 2 output ---"
162-
tail -n 60 "$PASS2_LOG" 2>/dev/null || true
163-
} > /tmp/droid-error.txt
147+
echo "droid exec pass 2 (validator) failed" > /tmp/droid-error.txt
164148
exit 1
165149
fi
166150
after_script:

0 commit comments

Comments
 (0)