Skip to content

feat: protocol TIER-3 schemas (cli, client, mcp, custom-models, mission-decomposition)#56

Merged
varin-nair-factory merged 1 commit into
mainfrom
vn/protocol-tier-3
Jun 1, 2026
Merged

feat: protocol TIER-3 schemas (cli, client, mcp, custom-models, mission-decomposition)#56
varin-nair-factory merged 1 commit into
mainfrom
vn/protocol-tier-3

Conversation

@varin-nair-factory

@varin-nair-factory varin-nair-factory commented May 30, 2026

Copy link
Copy Markdown
Contributor

What

Adds TIER-3 of the public-SDK protocol source-of-truth migration: verbatim mirrors of the private factory-mono-alpha CLI/client wire-protocol schemas into src/protocol/.

New files:

  • src/protocol/custom-models.ts — CustomModelBedrockSchema, ManagedCustomModelSchema (incl. apiKey/AWS fields + superRefine), CustomModelsSchema, SandboxModeSchema
  • src/protocol/mcp.ts — MCP server/registry/tool schemas
  • src/protocol/mission-decomposition.ts — mission feature / progress-log / file schemas
  • src/protocol/cli.ts — session notifications union, RequestPermission, AskUser, ToolConfirmation details, CliRequestOrNotificationSchema
  • src/protocol/client.ts — full daemon/server request/response surface (init/load session, MCP mgmt, tools, skills, context, rewind, compact, fork, rename)

Also: 6 new leaf enums added to enums.ts (ModelKind, LLMModelTier, SettingsLevel, DroidLocation, SkillLocation, SandboxMode); barrel + round-trip tests updated.

Why

Continues the strangler-fig migration toward making the public SDK the single source of truth for the daemon/CLI wire protocol, eliminating manual drift from the monorepo. Schemas are ported verbatim (only import-path rewrites to local ./ siblings + .js ESM extensions).

Notes

  • Not yet wired into the public API (src/index.ts); src/protocol/index.ts remains an internal barrel.
  • SessionTagSchema reuses the existing TIER-1 definition in session.ts (no duplicate).
  • Verification: npm run typecheck, npm run lint, npm run format:check, and full vitest suite (921 tests) all pass.

Base: vn/protocol-tier-2 (#53).

Closes CLI-756

Base automatically changed from vn/protocol-tier-2 to main June 1, 2026 18:24
@varin-nair-factory
varin-nair-factory dismissed factory-davidgu’s stale review June 1, 2026 18:24

The base branch was changed.

…ission-decomposition)

Verbatim mirrors of the private factory-mono-alpha CLI/client wire protocol,
extending the public source-of-truth protocol surface. Not yet wired into the
public package API.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@varin-nair-factory
varin-nair-factory merged commit 188b7a8 into main Jun 1, 2026
4 checks passed
@varin-nair-factory
varin-nair-factory deleted the vn/protocol-tier-3 branch June 1, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants