fix: convert namespace labels to a label Set instead of merging the map with itself#607
Open
AruneshDwivedi wants to merge 2 commits into
Open
Conversation
…ap with itself Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
…pace A namespace with a nil Labels map converts to an empty label Set, which must fail the selector match so the namespace is skipped rather than matched or panicking on the conversion. Assert that an unlabeled namespace is left out while a labeled one still receives the binding. Signed-off-by: Arunesh Dwivedi <arunesh.devops@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseRoleBinding built the label selector match by calling labels.Merge(namespace.Labels, namespace.Labels), merging the namespace label map with a copy of itself. That is a confused artifact, not a real merge, and the second argument exists only to satisfy the helper signature. labels.Set converts a map directly to a labels.Set, which is the documented way to build the Set that selector.Matches expects. Behavior is unchanged for the existing namespace-selector tests; the call just says what it means.