Skip to content

Commit d690d1b

Browse files
authored
docs: improve CONTRIBUTING with comprehensive descriptions and better readability (#921)
1 parent 011f56a commit d690d1b

1 file changed

Lines changed: 51 additions & 45 deletions

File tree

CONTRIBUTING.md

Lines changed: 51 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,74 +1,80 @@
1-
# Contributing to [github-readme-profile](https://github.com/FajarKim/github-readme-profile)
1+
# Contributing to GitHub Readme Profile
22

33
We love your input! We want to make contributing to this project as easy and transparent as possible, whether it's:
44

5-
- Reporting [an issue](https://github.com/FajarKim/github-readme-profile/issues/new?assignees=&labels=bug&template=bug_report.yml).
6-
- [Discussing](https://github.com/FajarKim/github-readme-profile/discussions) the current state of the code.
7-
- Submitting [a fix](https://github.com/FajarKim/github-readme-profile/compare).
8-
- Proposing [new features](https://github.com/FajarKim/github-readme-profile/issues/new?assignees=&labels=enhancement&template=feature_request.yml).
9-
- Becoming a maintainer.
5+
- Reporting [an issue](https://github.com/FajarKim/github-readme-profile/issues/new?assignees=&labels=bug&template=bug_report.yml).
6+
- [Discussing](https://github.com/FajarKim/github-readme-profile/discussions) the current state of the code.
7+
- Submitting [a fix](https://github.com/FajarKim/github-readme-profile/compare).
8+
- Proposing [new features](https://github.com/FajarKim/github-readme-profile/issues/new?assignees=&labels=enhancement&template=feature_request.yml).
9+
- Becoming a maintainer.
1010

11-
## 🌝 All Changes Happen Through Pull Requests
11+
## All Changes Happen Through Pull Requests
1212

1313
Pull requests are the best way to propose changes. We actively welcome your pull requests:
1414

15-
1. Fork the repo and create your branch from `master`.
16-
2. If you've added code that should be tested, add some tests' examples.
17-
3. If you've changed APIs, update the documentation.
18-
4. Issue that pull request!
15+
1. Fork the repo and create your branch from `master`.
16+
2. If you've added code that should be tested, add test examples.
17+
3. If you've changed APIs, update the documentation.
18+
4. Issue that pull request!
1919

20-
## 🎨 Themes Contribution
20+
## Theme Contribution
2121

22-
GitHub Readme Profile supports custom theming, and you can also contribute new themes!
22+
GitHub Readme Profile supports custom theming, and you can contribute new themes to the built‑in collection.
2323

24-
> [!NOTE]\
25-
> If you are contributing your theme just because you are using it personally, then you can [customize the looks](./README.md#customization) of your card with URL params instead.
24+
> [!NOTE]
25+
> If you are contributing a theme only for personal use, you can [customize the appearance](/README.md#customization) of your card with URL parameters instead, no pull request needed.
2626
27-
> [!NOTE]\
28-
> Your pull request with theme addition will be merged once we get enough positive feedback from the community in the form of thumbs up 👍 emojis. We expect to see at least 5-10 thumbs up before making a decision to merge your pull request into the master branch. Remember that you can also support themes of other contributors that you liked to speed up their merge.
27+
> [!NOTE]
28+
> Your pull request with a new theme will be merged once it receives enough positive feedback from the community (at least 510 👍 reactions). This helps ensure that only themes with broad appeal are included. You can also support themes from other contributors by upvoting them.
2929
30-
> [!NOTE]\
31-
> Before submitting pull request, please make sure that your theme pass WCAG 2.0 level AA contrast ration test. You can use [this tool](https://webaim.org/resources/contrastchecker/) to check it.
30+
> [!NOTE]
31+
> Before submitting your theme, please ensure it passes the **WCAG 2.0 Level AA** contrast ratio test. You can use [WebAIM’s contrast checker](https://webaim.org/resources/contrastchecker/) to verify.
3232
33-
To contribute your theme you need to edit the [themes/index.ts](/themes/index.ts) file and add it at the end of the file.
33+
To contribute a theme, edit the [`themes/index.ts`](/themes/index.ts) file and add your theme at the end of the file. Follow the existing structure: provide a descriptive name and a set of color definitions (`title_color`, `text_color`, `icon_color`, `border_color`, `bg_color`, etc.).
3434

35-
## 🗣️ Translations Contribution
36-
GitHub Readme Profile supports multiple languages, if we are missing your language, you can contribute it! You can check the currently supported languages [here](/README.md#available-locales).
35+
## Translations Contribution
3736

38-
To contribute your language you need to edit the [i18n/index.ts](/i18n/index.ts) file and add new property to each object where the key is the language code in ISO 639-1 standard and the value is the translated string. Anything appearing in [the list](https://gist.github.com/FajarKim/91516c2aecbfc8bf65f584d528d5f2b1) should be fine.
37+
GitHub Readme Profile supports multiple languages. If your language is missing, you can contribute a translation! See the currently supported languages in [`i18n/README.md`](/i18n/README.md).
3938

40-
## 📑 Any contributions you make will be under the MIT Software License
39+
To add a new language:
4140

42-
In short, when you submit changes, your submissions are understood to be under the same [MIT License](http://choosealicense.com/licenses/mit/) that covers the project. Feel free to contact the maintainers if that's a concern.
41+
1. Edit the [`i18n/index.ts`](/i18n/index.ts) file.
42+
2. Add a new property to each translation object using the language code as the key. The code should follow the ISO 639-1 standard (e.g., `id`, `fr`, `ja`). Country‑specific codes like `pt-BR` are also acceptable.
43+
3. Provide the translated strings for all keys. You can use the existing translations as a reference.
4344

44-
## ⚠️ Report issues/bugs using GitHub's [issues](https://github.com/FajarKim/github-readme-profile/issues)
45+
If you are unsure about the language code, check [this list](https://gist.github.com/FajarKim/91516c2aecbfc8bf65f584d528d5f2b1) for accepted codes.
4546

46-
We use GitHub issues to track public bugs. Report a bug by [opening a new issue](https://github.com/FajarKim/github-readme-profile/issues/new/choose); it's that easy!
47+
## Any Contributions You Make Will Be Under the MIT Software License
48+
49+
When you submit changes, your submissions are understood to be under the same [MIT License](http://choosealicense.com/licenses/mit/) that covers the project. If that's a concern, please contact the maintainers.
4750

48-
### 🚨 Bug Reports
51+
## Report Issues or Bugs Using GitHub Issues
52+
53+
We use GitHub issues to track public bugs. Report a bug by [opening a new issue](https://github.com/FajarKim/github-readme-profile/issues/new/choose); it's that easy!
4954

50-
**Great Bug Reports** tend to have:
55+
### Bug Reports
5156

52-
- A quick summary and/or background
53-
- Steps to reproduce
54-
- Be specific!
55-
- Share the snapshot, if possible.
56-
- GitHub Readme Stats' live link
57-
- What actually happens
58-
- What you expected would happen
59-
- Notes (possibly including why you think this might be happening or stuff you tried that didn't work)
57+
**Great bug reports** tend to have:
6058

61-
People ❤️ thorough bug reports. I'm not even kidding.
59+
- A quick summary and/or background
60+
- Steps to reproduce:
61+
- Be specific!
62+
- Include a snapshot or screenshot if possible.
63+
- Provide a live link to the affected card (e.g., `https://gh-readme-profile.vercel.app/api?username=...`)
64+
- What actually happens
65+
- What you expected to happen
66+
- Notes (possible causes, things you tried that didn't work)
6267

68+
People ❤️ thorough bug reports, we’re not even kidding.
6369

64-
### 😎 Feature Request
70+
### Feature Requests
6571

66-
**Great Feature Requests** tend to have:
72+
**Great feature requests** tend to have:
6773

68-
- A quick idea summary
69-
- What & why do you want to add the specific feature
70-
- Additional context like images, links to resources to implement the feature, etc.
74+
- A clear idea summary
75+
- What you want to add and why
76+
- Additional context (images, links to resources, implementation ideas)
7177

72-
## 📖 License
78+
## License
7379

74-
By contributing, you agree that your contributions will be licensed under its [MIT License](./LICENSE).
80+
By contributing, you agree that your contributions will be licensed under the project's [MIT License](/LICENSE).

0 commit comments

Comments
 (0)