Skip to content

refactor(card): simplify card generation#939

Merged
FajarKim merged 3 commits intomasterfrom
simplify-code
Apr 1, 2026
Merged

refactor(card): simplify card generation#939
FajarKim merged 3 commits intomasterfrom
simplify-code

Conversation

@FajarKim
Copy link
Copy Markdown
Owner

@FajarKim FajarKim commented Apr 1, 2026

Description

Simplify card generator code.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Misc change (updated other files non-breaking change)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with npm test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

None

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
github-readme-profile Ready Ready Preview, Comment Apr 1, 2026 11:57am

@github-actions github-actions Bot added the card label Apr 1, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.27%. Comparing base (84d8e2d) to head (85d55f0).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/card.ts 96.61% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   63.57%   68.27%   +4.69%     
==========================================
  Files          13       13              
  Lines         302      290      -12     
  Branches       81       70      -11     
==========================================
+ Hits          192      198       +6     
+ Misses         88       86       -2     
+ Partials       22        6      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FajarKim FajarKim merged commit 051c535 into master Apr 1, 2026
12 checks passed
@FajarKim FajarKim deleted the simplify-code branch April 1, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant