Skip to content

refactor(card): positioning logic into config object #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FajarKim merged 1 commit into from
Apr 2, 2026
+31 −13
Merged

refactor(card): positioning logic into config object #941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 31 additions & 13 deletions src/card.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,20 +97,38 @@ function getPositions(
isAnimDisabled: boolean | undefined,
isRevert: boolean | undefined
) {
const titleX = isAnimDisabled ? (isRtl ? 520 : 15) : (isRtl ? 510 : 5);
const titleY = isAnimDisabled ? 0 : -10;
const textX = isRtl ? 225 : 20;
const dataX = isRtl ? 25 : 220;
const iconX = isRtl ? 235 : -5;
const imageX = isAnimDisabled ? (isRevert ? 412 : 122) : (isRevert ? 417 : 127);
const imageY = isAnimDisabled ? 70 : 65;
const userX = isAnimDisabled ? (isRevert ? 412 : 122) : (isRevert ? 402 : 112);
const userY = isAnimDisabled ? 140 : 130;
const follX = isAnimDisabled ? (isRevert ? 412 : 122) : (isRevert ? 402 : 112);
const follY = isAnimDisabled ? 161 : 151;
const itemStatsX = isRevert ? (isRtl ? 10 : 0) : 230;
const configs = {
animated: {
title: { x: isRtl ? 510 : 5, y: -10 },
image: { x: isRevert ? 417 : 127, y: 65 },
user: { x: isRevert ? 402 : 112, y: 130 },
foll: { x: isRevert ? 402 : 112, y: 151 },
},
static: {
title: { x: isRtl ? 520 : 15, y: 0 },
image: { x: isRevert ? 412 : 122, y: 70 },
user: { x: isRevert ? 412 : 122, y: 140 },
foll: { x: isRevert ? 412 : 122, y: 161 },
},
};

const mode = isAnimDisabled ? "static" : "animated";
const config = configs[mode];

return { titleX, titleY, textX, dataX, iconX, imageX, imageY, userX, userY, follX, follY, itemStatsX };
return {
titleX: config.title.x,
titleY: config.title.y,
textX: isRtl ? 225 : 20,
dataX: isRtl ? 25 : 220,
iconX: isRtl ? 235 : -5,
imageX: config.image.x,
imageY: config.image.y,
userX: config.user.x,
userY: config.user.y,
follX: config.foll.x,
follY: config.foll.y,
itemStatsX: isRevert ? (isRtl ? 10 : 0) : 230,
};
}

/**
Expand Down
Loading