Skip to content

Commit 30b6e67

Browse files
Format
1 parent b156678 commit 30b6e67

4 files changed

Lines changed: 24 additions & 39 deletions

File tree

gcs/src/components/settingsModal.jsx

Lines changed: 19 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ const STREAM_MAP = {
4141
MAV_DATA_STREAM_RAW_SENSORS: 1,
4242
MAV_DATA_STREAM_EXTENDED_STATUS: 2,
4343
MAV_DATA_STREAM_RC_CHANNELS: 3,
44-
MAV_DATA_STREAM_RAW_CONTROLLER: 4 ,
44+
MAV_DATA_STREAM_RAW_CONTROLLER: 4,
4545
MAV_DATA_STREAM_POSITION: 6,
4646
MAV_DATA_STREAM_EXTRA1: 10,
4747
MAV_DATA_STREAM_EXTRA2: 11,
48-
MAV_DATA_STREAM_EXTRA3: 12
48+
MAV_DATA_STREAM_EXTRA3: 12,
4949
}
5050

5151
const isValidNumber = (num, range) => {
@@ -216,32 +216,17 @@ function SetRatesRow() {
216216
const dispatch = useDispatch()
217217

218218
const onClick = () => {
219-
const MAV_DATA_STREAM_ALL = getSetting("Developer.MAV_DATA_STREAM_ALL")
220-
const MAV_DATA_STREAM_RAW_SENSORS = getSetting("Developer.MAV_DATA_STREAM_RAW_SENSORS")
221-
const MAV_DATA_STREAM_EXTENDED_STATUS = getSetting("Developer.MAV_DATA_STREAM_EXTENDED_STATUS")
222-
const MAV_DATA_STREAM_RC_CHANNELS = getSetting("Developer.MAV_DATA_STREAM_RC_CHANNELS")
223-
const MAV_DATA_STREAM_RAW_CONTROLLER = getSetting("Developer.MAV_DATA_STREAM_RAW_CONTROLLER")
224-
const MAV_DATA_STREAM_POSITION = getSetting("Developer.MAV_DATA_STREAM_POSITION")
225-
const MAV_DATA_STREAM_EXTRA1 = getSetting("Developer.MAV_DATA_STREAM_EXTRA1")
226-
const MAV_DATA_STREAM_EXTRA2 = getSetting("Developer.MAV_DATA_STREAM_EXTRA2")
227-
const MAV_DATA_STREAM_EXTRA3 = getSetting("Developer.MAV_DATA_STREAM_EXTRA3")
228-
229-
230219
for (const [name, value] of Object.entries(STREAM_MAP)) {
231220
let rate = getSetting(`Developer.${name}`)
232-
dispatch(emitSetStreamRates({stream: value, rate: rate}))
221+
dispatch(emitSetStreamRates({ stream: value, rate: rate }))
233222
}
234223
}
235224

236225
return (
237-
<div className="px-10 flex items-center gap-4">
238-
<div className="flex-1">
239-
</div>
240-
<div className="flex-2 items-center gap-2">
241-
<Button size="xs" color="blue" onClick={onClick}>
242-
Set rates
243-
</Button>
244-
</div>
226+
<div className="mt-0! px-10 flex justify-end">
227+
<Button size="compact-xs" color="blue" onClick={onClick}>
228+
Set rates
229+
</Button>
245230
</div>
246231
)
247232
}
@@ -348,12 +333,12 @@ function ExtendableTextSetting({ settingName, df }) {
348333
const [items, setItems] = useState(
349334
getSetting(settingName).length > 0
350335
? getSetting(settingName).map((item) => {
351-
const newItem = { id: generateId() }
352-
df.fields.forEach((field) => {
353-
newItem[field.key] = item[field.key] || ""
336+
const newItem = { id: generateId() }
337+
df.fields.forEach((field) => {
338+
newItem[field.key] = item[field.key] || ""
339+
})
340+
return newItem
354341
})
355-
return newItem
356-
})
357342
: [],
358343
)
359344

@@ -618,7 +603,7 @@ function Setting({ settingName, df, initialValue }) {
618603

619604
setChangedFromDefault(
620605
!["[]", '""'].includes(JSON.stringify(df.default)) &&
621-
JSON.stringify(getSetting(settingName)) != JSON.stringify(df.default),
606+
JSON.stringify(getSetting(settingName)) != JSON.stringify(df.default),
622607
)
623608
}, [getSetting(settingName)])
624609

@@ -791,7 +776,10 @@ function SettingsModal() {
791776
<Tabs.List>
792777
{settingTabs.map((t) => {
793778
// Only show developer tag when developer features are on
794-
if (!getSetting("General.experimentalDeveloperFeatures") && t === "Developer") {
779+
if (
780+
!getSetting("General.experimentalDeveloperFeatures") &&
781+
t === "Developer"
782+
) {
795783
return <></>
796784
}
797785
return (
@@ -854,8 +842,7 @@ function SettingsModal() {
854842
<>
855843
<SetRatesRow />
856844
</>
857-
)
858-
}
845+
)}
859846
</Tabs.Panel>
860847
)
861848
})}
@@ -879,7 +866,7 @@ function SettingsModal() {
879866
setting
880867
.split(".")
881868
.reduce((title, value) => title[value], DefaultSettings)[
882-
"display"
869+
"display"
883870
]
884871
}
885872
</p>

gcs/src/redux/middleware/emitters.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ export function handleEmitters(socket, store, action) {
216216
callback: () =>
217217
socket.socket.emit("set_stream_rate", {
218218
stream: action.payload.stream,
219-
rate: action.payload.rate
220-
})
219+
rate: action.payload.rate,
220+
}),
221221
},
222222

223223
{

gcs/src/redux/slices/droneConnectionSlice.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ const droneConnectionSlice = createSlice({
188188
emitTakeoff: () => {},
189189
emitLand: () => {},
190190
emitSetCurrentFlightMode: () => {},
191-
emitSetStreamRates: () => {}
191+
emitSetStreamRates: () => {},
192192
},
193193
selectors: {
194194
selectConnecting: (state) => state.connecting,
@@ -264,7 +264,7 @@ export const {
264264
emitTakeoff,
265265
emitLand,
266266
emitSetCurrentFlightMode,
267-
emitSetStreamRates
267+
emitSetStreamRates,
268268
} = droneConnectionSlice.actions
269269
export const {
270270
selectConnecting,

radio/app/endpoints/params.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,7 @@ def set_multiple_params(params_list: List[Any]) -> None:
3939
if droneStatus.state != "params":
4040
socketio.emit(
4141
"params_error",
42-
{
43-
"message": "You must be on the params screen to save parameters."
44-
},
42+
{"message": "You must be on the params screen to save parameters."},
4543
)
4644
logger.debug(f"Current state: {droneStatus.state}")
4745
return

0 commit comments

Comments
 (0)