Address copilot review comments

Author: 1Blademaster

gcs/src/components/mapComponents/fenceItems.jsx

@@ -25,6 +25,23 @@ import DrawLineCoordinates from "./drawLineCoordinates"
 import MarkerPin from "./markerPin"
 const tailwindColors = resolveConfig(tailwindConfig).theme.colors
 
+function getFenceCommandNumber(value) {
+  return parseInt(
+    Object.keys(FENCE_ITEM_COMMANDS_LIST).filter(
+      (key) => FENCE_ITEM_COMMANDS_LIST[key] === value,
+    ),
+  )
+}
+
+const polygonCommands = [
+  getFenceCommandNumber("MAV_CMD_NAV_FENCE_POLYGON_VERTEX_INCLUSION"),
+  getFenceCommandNumber("MAV_CMD_NAV_FENCE_POLYGON_VERTEX_EXCLUSION"),
+]
+const circleCommands = [
+  getFenceCommandNumber("MAV_CMD_NAV_FENCE_CIRCLE_INCLUSION"),
+  getFenceCommandNumber("MAV_CMD_NAV_FENCE_CIRCLE_EXCLUSION"),
+]
+
 export default function FenceItems({
   fenceItems,
   editable = false,
@@ -34,24 +51,7 @@ export default function FenceItems({
   const [fenceCircleItems, setFenceCircleItems] = useState([])
 
   useEffect(() => {
-    function getFenceCommandNumber(value) {
-      return parseInt(
-        Object.keys(FENCE_ITEM_COMMANDS_LIST).filter(
-          (key) => FENCE_ITEM_COMMANDS_LIST[key] === value,
-        ),
-      )
-    }
-
     // Filter out fence items based on their type
-    const polygonCommands = [
-      getFenceCommandNumber("MAV_CMD_NAV_FENCE_POLYGON_VERTEX_INCLUSION"),
-      getFenceCommandNumber("MAV_CMD_NAV_FENCE_POLYGON_VERTEX_EXCLUSION"),
-    ]
-    const circleCommands = [
-      getFenceCommandNumber("MAV_CMD_NAV_FENCE_CIRCLE_INCLUSION"),
-      getFenceCommandNumber("MAV_CMD_NAV_FENCE_CIRCLE_EXCLUSION"),
-    ]
-
     const polygonItems = fenceItems.filter((item) =>
       polygonCommands.includes(item.command),
     )

gcs/src/components/missions/fenceItemsTableRow.jsx

@@ -19,6 +19,25 @@ import {
 
 const coordsFractionDigits = 9
 
+function getAvailableCommands() {
+  var commandsList = FENCE_ITEM_COMMANDS_LIST
+
+  return Object.entries(commandsList).map(([key, value]) => ({
+    value: key,
+    label: getDisplayCommandName(value),
+  }))
+}
+
+function getFrameName(frameId) {
+  var frameName = MAV_FRAME_LIST[frameId]
+
+  if (frameName.startsWith("MAV_FRAME_")) {
+    frameName = frameName.replace("MAV_FRAME_", "")
+  }
+
+  return frameName || "UNKNOWN"
+}
+
 export default function FenceItemsTableRow({
   index,
   fenceItem,
@@ -46,25 +65,6 @@ export default function FenceItemsTableRow({
     return commandName
   }
 
-  function getAvailableCommands() {
-    var commandsList = FENCE_ITEM_COMMANDS_LIST
-
-    return Object.entries(commandsList).map(([key, value]) => ({
-      value: key,
-      label: getDisplayCommandName(value),
-    }))
-  }
-
-  function getFrameName(frameId) {
-    var frameName = MAV_FRAME_LIST[frameId]
-
-    if (frameName.startsWith("MAV_FRAME_")) {
-      frameName = frameName.replace("MAV_FRAME_", "")
-    }
-
-    return frameName || "UNKNOWN"
-  }
-
   function updateFenceItemData(key, newVal) {
     setFenceItemData({
       ...fenceItemData,

gcs/src/missions.jsx

@@ -623,7 +623,7 @@ export default function Missions() {
   }
 
   function addFencePolygon(newFenceItems) {
-    var seqNumber =
+    let seqNumber =
       fenceItems.length > 0 ? fenceItems[fenceItems.length - 1].seq + 1 : 0
 
     const newFenceMissionItems = newFenceItems.map((item) => {